Skip to content

Commit 5a3013c

Browse files
committed
Remove usage of RequestContext
1 parent 1dd661a commit 5a3013c

2 files changed

Lines changed: 16 additions & 11 deletions

File tree

codespeed/tests/test_views.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,13 @@ def test_fixture(self):
333333
results = benchmarks[0].results.all()
334334
self.assertEquals(len(results), 8)
335335

336+
def test_timeline(self):
337+
path = reverse('timeline')
338+
response = self.client.get(path)
339+
self.assertEquals(response.status_code, 200)
340+
responsedata = response.content.decode()
341+
self.assertIn('My Own Title\n: Timeline', responsedata)
342+
336343
def test_gettimelinedata(self):
337344
"""Test that gettimelinedata returns correct timeline data
338345
"""

codespeed/views.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from django.shortcuts import get_object_or_404, render_to_response
1515
from django.views.decorators.http import require_GET, require_POST
1616
from django.views.decorators.csrf import csrf_exempt
17-
from django.template import RequestContext
1817

1918
from .auth import basic_auth_required
2019
from .models import (Environment, Report, Project, Revision, Result,
@@ -36,7 +35,7 @@ def no_environment_error(request):
3635
'message': ('You need to configure at least one Environment. '
3736
'Please go to the '
3837
'<a href="%s">admin interface</a>' % admin_url)
39-
}, context_instance=RequestContext(request))
38+
})
4039

4140

4241
def no_default_project_error(request):
@@ -46,19 +45,19 @@ def no_default_project_error(request):
4645
'default (checked "Track changes" field).<br />'
4746
'Please go to the '
4847
'<a href="%s">admin interface</a>' % admin_url)
49-
}, context_instance=RequestContext(request))
48+
})
5049

5150

5251
def no_executables_error(request):
5352
return render_to_response('codespeed/nodata.html', {
5453
'message': 'There needs to be at least one executable'
55-
}, context_instance=RequestContext(request))
54+
})
5655

5756

5857
def no_data_found(request):
5958
return render_to_response('codespeed/nodata.html', {
6059
'message': 'No data found'
61-
}, context_instance=RequestContext(request))
60+
})
6261

6362

6463
@require_GET
@@ -223,7 +222,7 @@ def comparison(request):
223222
'selectedbaseline': selectedbaseline,
224223
'selectedchart': selectedchart,
225224
'selecteddirection': selecteddirection
226-
}, context_instance=RequestContext(request))
225+
})
227226

228227

229228
@require_GET
@@ -503,7 +502,7 @@ def timeline(request):
503502
'defaultquarts': defaultquarts,
504503
'defaultextr': defaultextr,
505504
'use_median_bands': use_median_bands,
506-
}, context_instance=RequestContext(request))
505+
})
507506

508507

509508
@require_GET
@@ -577,7 +576,7 @@ def getchangestable(request):
577576
'env': environment,
578577
'prev': prevrev,
579578
'next': nextrev,
580-
}, context_instance=RequestContext(request))
579+
})
581580

582581

583582
@require_GET
@@ -688,7 +687,7 @@ def changes(request):
688687
'projectmatrix': projectmatrix,
689688
'revisionlists': revisionlists,
690689
'trends': trends,
691-
}, context_instance=RequestContext(request))
690+
})
692691

693692

694693
@require_GET
@@ -752,8 +751,7 @@ def displaylogs(request):
752751
{
753752
'error': error, 'logs': logs,
754753
'show_email_address': settings.SHOW_AUTHOR_EMAIL_ADDRESS
755-
},
756-
context_instance=RequestContext(request))
754+
})
757755

758756

759757
@csrf_exempt

0 commit comments

Comments
 (0)