From 74a7f80657f7eec7f3c2d1c12009ec0c105c5d40 Mon Sep 17 00:00:00 2001 From: Brian M Date: Fri, 9 May 2025 11:56:45 -0700 Subject: [PATCH 1/2] Fix tests for modern cython --- tests/iscsi_test.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tests/iscsi_test.py b/tests/iscsi_test.py index 65cebaf..0a4d748 100644 --- a/tests/iscsi_test.py +++ b/tests/iscsi_test.py @@ -17,26 +17,32 @@ def test_url_parse(self): def test_set_context_params(self): context = iscsi.Context("foobar") context.set_targetname("my-target") - context.set_header_digest(iscsi.ISCSI_HEADER_DIGEST_NONE) + context.set_header_digest(iscsi.iscsi_header_digest.ISCSI_HEADER_DIGEST_NONE) def test_command(self): context = iscsi.Context("foobar") - task = iscsi.Task(b"\x12\x00\x00\x00\x60\x00", iscsi.SCSI_XFER_READ, 96) + task = iscsi.Task( + b"\x12\x00\x00\x00\x60\x00", iscsi.scsi_xfer_dir.SCSI_XFER_READ, 96 + ) data_in = bytearray(96) context.command(0, task, None, data_in) class TaskTest(unittest.TestCase): def test_basic(self): - task = iscsi.Task(b"\x12\x00\x00\x00\x60\x00", iscsi.SCSI_XFER_READ, 96) + task = iscsi.Task( + b"\x12\x00\x00\x00\x60\x00", iscsi.scsi_xfer_dir.SCSI_XFER_READ, 96 + ) self.assertIsNotNone(task) def test_bytearray(self): task = iscsi.Task( - bytearray(b"\x12\x00\x00\x00\x60\x00"), iscsi.SCSI_XFER_READ, 96 + bytearray(b"\x12\x00\x00\x00\x60\x00"), + iscsi.scsi_xfer_dir.SCSI_XFER_READ, + 96, ) self.assertIsNotNone(task) def test_empty_cdb(self): with self.assertRaises(ValueError): - iscsi.Task(None, iscsi.SCSI_XFER_READ, 96) + iscsi.Task(None, iscsi.scsi_xfer_dir.SCSI_XFER_READ, 96) From a7959df177523fecbf2b8eb9f5fa2cbdf6ff6ca3 Mon Sep 17 00:00:00 2001 From: Brian M Date: Fri, 9 May 2025 12:22:30 -0700 Subject: [PATCH 2/2] Update pre-commit.yml using latest version of precommit --- .github/workflows/pre-commit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index b9655e6..2095198 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -15,4 +15,4 @@ jobs: steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v2 - - uses: pre-commit/action@v2.0.0 + - uses: pre-commit/action@v3.0.1