Fix more $ref cases when the lookup URL is different from an $id

Passes a few more of the just-added upstream tests (and in particular
is a last URN $id-related fix).

One test still fails which is waiting for more tweaks to how remote ref
lookups are done.

Author: Julian

jsonschema/tests/test_jsonschema_test_suite.py

@@ -396,6 +396,11 @@ def leap_second(test):
                 "not just immediate parent"
             ),
         )(test)
+        or skip(
+            message=bug(),
+            subject="refRemote",
+            case_description="remote HTTP ref with nested absolute ref",
+        )(test)
     ),
 )
 
@@ -516,6 +521,11 @@ def leap_second(test):
                 "not just immediate parent"
             ),
         )(test)
+        or skip(
+            message=bug(),
+            subject="refRemote",
+            case_description="remote HTTP ref with nested absolute ref",
+        )(test)
     ),
 )
 

jsonschema/validators.py

@@ -16,6 +16,7 @@
 import typing
 import warnings
 
+from pyrsistent import m
 import attr
 
 from jsonschema import (
@@ -713,7 +714,7 @@ def __init__(
         self,
         base_uri,
         referrer,
-        store=(),
+        store=m(),
         cache_remote=True,
         handlers=(),
         urljoin_cache=None,
@@ -729,8 +730,13 @@ def __init__(
         self.handlers = dict(handlers)
 
         self._scopes_stack = [base_uri]
+
         self.store = _utils.URIDict(_store_schema_list())
         self.store.update(store)
+        self.store.update(
+            (schema["$id"], schema)
+            for schema in store.values() if "$id" in schema
+        )
         self.store[base_uri] = referrer
 
         self._urljoin_cache = urljoin_cache
@@ -864,6 +870,7 @@ def _find_in_subschemas(self, url):
             if target_uri.rstrip("/") == uri.rstrip("/"):
                 if fragment:
                     subschema = self.resolve_fragment(subschema, fragment)
+                self.store[url] = subschema
                 return url, subschema
         return None
 
@@ -884,16 +891,16 @@ def resolve_from_url(self, url):
         Resolve the given URL.
         """
         url, fragment = urldefrag(url)
-        if url:
+        if not url:
+            url = self.base_uri
+
+        try:
+            document = self.store[url]
+        except KeyError:
             try:
-                document = self.store[url]
-            except KeyError:
-                try:
-                    document = self.resolve_remote(url)
-                except Exception as exc:
-                    raise exceptions.RefResolutionError(exc)
-        else:
-            document = self.referrer
+                document = self.resolve_remote(url)
+            except Exception as exc:
+                raise exceptions.RefResolutionError(exc)
 
         return self.resolve_fragment(document, fragment)