Skip to content

docs: fix Solana push feed ids and accounts#3753

Open
dl-bot-integrations wants to merge 1 commit into
mainfrom
docs/fix-solana-push-feeds
Open

docs: fix Solana push feed ids and accounts#3753
dl-bot-integrations wants to merge 1 commit into
mainfrom
docs/fix-solana-push-feeds

Conversation

@dl-bot-integrations
Copy link
Copy Markdown
Collaborator

@dl-bot-integrations dl-bot-integrations commented May 22, 2026 •
edited by devin-ai-integration Bot
Loading

Summary

  • fix 18 incorrect Solana shard-0 account addresses in the Solana push feeds table
  • fix the INF/SOL push feed id (it was pointing at LINEA/USD)
  • rename INDEX.FORD/USD to INDEX.FWDI/USD to match the live feed id and derived account

Verification

  • compared every row against the live Hermes stable feed catalog (https://hermes.pyth.network/v2/price_feeds)
  • derived shard-0 Solana push-feed accounts using the same getPriceFeedAccountForProgram(0, feedId) PDA rule used by the legacy PriceFeedIds page
  • re-ran a full row-by-row check after the patch: no remaining id/account mismatches
Open in Devin Review

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
component-library Ready Ready Preview, Comment May 22, 2026 3:36pm
developer-hub Ready Ready Preview, Comment May 22, 2026 3:36pm
5 Skipped Deployments
Project Deployment Actions Updated (UTC)
api-reference Skipped Skipped May 22, 2026 3:36pm
entropy-explorer Skipped Skipped May 22, 2026 3:36pm
insights Skipped Skipped May 22, 2026 3:36pm
proposals Skipped Skipped May 22, 2026 3:36pm
staking Skipped Skipped May 22, 2026 3:36pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026 •
edited
Loading

⚠️ Review Required: A human is required to review bot PRs. 2 different human approvals are required before this PR can be merged.

Current approvals: none
Missing: 2

devin-ai-integration[bot]
devin-ai-integration Bot reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread apps/developer-hub/content/docs/price-feeds/core/push-feeds/data/svm/solana-mainnet.json
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Account address changes cannot be verified on-chain from code review alone

This PR updates ~20 account addresses to new values. While the format is valid (base58, correct length range 32-44 chars) and the commit message says "fix solana push feed ids and accounts", the correctness of the actual on-chain addresses cannot be verified purely from code review. The reviewer should confirm these were derived from the Pyth oracle deployment or a trusted source.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dl-bot-integrations