From c4ca56ae2b44cd8de6395516e16459c5b62cd37b Mon Sep 17 00:00:00 2001 From: 0xghost42 Date: Wed, 13 May 2026 15:56:33 +0530 Subject: [PATCH] docs(aptos): document why framework dependency revisions are pinned MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Closes #2511. The Move.toml in target_chains/aptos/contracts pins AptosFramework, MoveStdlib, AptosStdlib, and AptosToken to a specific aptos-core revision that predates several recent mainnet upgrades. Without context, contributors keep filing issues / PRs proposing to bump these revs to 'latest mainnet' — which would silently break ABI compatibility with the on-chain Wormhole package the Pyth contract depends on. Add a comment above the dependencies block explaining why the rev is locked and that it cannot be bumped in isolation from a coordinated Wormhole upgrade on every supported network. --- target_chains/aptos/contracts/Move.toml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/target_chains/aptos/contracts/Move.toml b/target_chains/aptos/contracts/Move.toml index 4ff4523252..a7072dce47 100644 --- a/target_chains/aptos/contracts/Move.toml +++ b/target_chains/aptos/contracts/Move.toml @@ -4,6 +4,12 @@ version = "0.0.1" upgrade_policy = "compatible" [dependencies] +# The AptosFramework / MoveStdlib / AptosStdlib / AptosToken revisions below +# are pinned to match the version of `aptos-core` that the on-chain Wormhole +# package (pinned just under here) was compiled and deployed against. Bumping +# them in isolation will produce bytecode that no longer links against the +# deployed Wormhole package, so do not update either pin without coordinating a +# matching Wormhole upgrade on every network we ship to. AptosFramework = { git = "https://github.com/aptos-labs/aptos-core.git", subdir = "aptos-move/framework/aptos-framework/", rev = "6f83bc6d02207298b2dee91133d75538789bf582" } MoveStdlib = { git = "https://github.com/aptos-labs/aptos-core.git", subdir = "aptos-move/framework/move-stdlib/", rev = "6f83bc6d02207298b2dee91133d75538789bf582" } AptosStdlib = { git = "https://github.com/aptos-labs/aptos-core.git", subdir = "aptos-move/framework/aptos-stdlib/", rev = "6f83bc6d02207298b2dee91133d75538789bf582" }