Merge pull request #3306 from pyth-network/bduran/fix-runahead-bug

fix(insights hub): fixed run ahead bug by emitting data points in time-based order, regardless of their source

Author: benduran

apps/insights/package.json

@@ -87,4 +87,4 @@
     "stylelint-config-standard-scss": "catalog:",
     "vercel": "catalog:"
   }
-}
+}

apps/insights/public/db/historical-demo-data.db

@@ -1,7 +1,7 @@
 import { NextRequest, NextResponse } from "next/server";
 
-import { fetchHistoricalDataForPythFeedsDemo } from "../../../../../../pyth-feed-demo-data/fetch-historical-data-from-db";
-import { GetPythFeedsDemoDataRequestSchema } from "../../../../../../schemas/pyth/pyth-pro-demo-schema";
+import { fetchHistoricalDataForPythFeedsDemo } from "../../../../../pyth-feed-demo-data/fetch-historical-data-from-db";
+import { GetPythFeedsDemoDataRequestSchema } from "../../../../../schemas/pyth/pyth-pro-demo-schema";
 
 export const GET = async (
   req: NextRequest,
@@ -11,28 +11,34 @@ export const GET = async (
   const {
     nextUrl: { searchParams },
   } = req;
+
+  const searchParamsToUse = {
+    ...Object.fromEntries(searchParams),
+    datasources: searchParams.getAll("datasources[]"),
+  };
+
   const paramsAndQueryValidation = GetPythFeedsDemoDataRequestSchema.safeParse({
     params,
-    searchParams: Object.fromEntries(searchParams),
+    searchParams: searchParamsToUse,
   });
 
   if (paramsAndQueryValidation.error) {
     return NextResponse.json(
       {
-        error: paramsAndQueryValidation.error.message,
+        error: paramsAndQueryValidation.error.format(),
       },
       { status: 400 },
     );
   }
 
   const {
-    params: { datasource: datasourceToUse, symbol: symbolToUse },
-    searchParams: { startAt },
+    params: { symbol: symbolToUse },
+    searchParams: { datasources, startAt },
   } = paramsAndQueryValidation.data;
 
   try {
     const { data, hasNext } = await fetchHistoricalDataForPythFeedsDemo({
-      datasource: datasourceToUse,
+      datasources,
       startAt: startAt.toISOString(),
       symbol: symbolToUse,
     });

…demo-data/[datasource]/[symbol]/route.ts …t-pyth-feeds-demo-data/[symbol]/route.tsapps/insights/src/app/api/pyth/get-pyth-feeds-demo-data/[datasource]/[symbol]/route.ts renamed to apps/insights/src/app/api/pyth/get-pyth-feeds-demo-data/[symbol]/route.ts apps/insights/src/app/api/pyth/get-pyth-feeds-demo-data/[datasource]/[symbol]/route.ts renamed to apps/insights/src/app/api/pyth/get-pyth-feeds-demo-data/[symbol]/route.ts

@@ -18,6 +18,7 @@ import {
   datasourceRequiresApiToken,
   getColorForDataSource,
   isAllowedSymbol,
+  isReplaySymbol,
 } from "../../util/pyth-pro-demo";
 
 type PriceCardProps = {
@@ -102,7 +103,9 @@ export function PythProDemoCard({
         {socketStatus && (
           <div className={classes.socketStatus}>
             {/* the token is either missing or it's a bad token */}
-            {requiresToken && (!apiToken || socketStatus === "closed") ? (
+            {!isReplaySymbol(selectedSource) &&
+            requiresToken &&
+            (!apiToken || socketStatus === "closed") ? (
               <>
                 Please enter a good API token
                 <br />

apps/insights/src/components/PythProDemoCards/price-card.tsx

@@ -188,10 +188,9 @@ export function PythProDemoPriceChartImpl({
           // data will track the price.
           // for market data, we just want to display the ask and bid
           const isPriceMetric = metricType === "price";
-          const isNasdaq = dataSource === "nasdaq";
+          const isNbbo = dataSource === "nbbo";
           const isPyth = dataSource === "pyth" || dataSource === "pyth_pro";
-          if ((isNasdaq && isPriceMetric) || (isPyth && !isPriceMetric))
-            continue;
+          if ((isNbbo && isPriceMetric) || (isPyth && !isPriceMetric)) continue;
 
           const latest = metrics[dataSource]?.latest;
           const symbolMetrics = latest?.[selectedSource];

apps/insights/src/components/PythProDemoPriceChart/index.tsx

@@ -72,8 +72,8 @@ export function WebSocketsProvider({ children }: PropsWithChildren) {
   // "Fake" websocket-like contract for easier integration
   const { status: replay_status } = useHttpDataStream({
     dataSources: [
+      ALL_DATA_SOURCES.Values.nbbo,
       ALL_DATA_SOURCES.Values.pyth_pro,
-      ALL_DATA_SOURCES.Values.nasdaq,
     ],
     enabled: isGoodSymbol && isReplaySymbol(selectedSource),
     symbol: selectedSource,
@@ -87,10 +87,9 @@ export function WebSocketsProvider({ children }: PropsWithChildren) {
         bybit,
         coinbase,
         okx,
-        nasdaq: replay_status,
+        nbbo: replay_status,
         pyth,
         pyth_pro: isReplaySymbol(selectedSource) ? replay_status : pyth_pro,
-        yahoo: "connected",
       },
     }),
     [