Skip to content

Commit 360f33e

Browse files
committed
fix: skeleton fill
1 parent e368873 commit 360f33e

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

packages/component-library/src/Skeleton/index.module.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@
1111
}
1212
}
1313

14-
.fullSkeleton {
15-
display: inline-block;
16-
}
17-
1814
.skeleton {
1915
border-radius: theme.border-radius("lg");
2016

17+
.fullSkeleton {
18+
width: 100%;
19+
}
20+
2121
.skeletonInner {
2222
display: inline flow-root;
2323
width: calc(theme.spacing(1) * var(--skeleton-width));

packages/component-library/src/Skeleton/index.stories.tsx

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,17 @@ export const Skeleton = {
3131
args: {
3232
label: "Loading",
3333
width: 20,
34-
fill: false,
3534
},
3635
} satisfies StoryObj<typeof SkeletonComponent>;
36+
37+
export const SkeletonFill: StoryObj<typeof SkeletonComponent> = {
38+
render: (args) => (
39+
<div style={{ width: "100vw" }}>
40+
<SkeletonComponent {...args} />
41+
</div>
42+
),
43+
args: {
44+
label: "Loading",
45+
fill: true,
46+
},
47+
};

packages/component-library/src/Skeleton/index.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,15 @@ type Props = Omit<ComponentProps<"span">, "children"> & {
1212
};
1313

1414
export const Skeleton = ({ className, label, width, fill, ...props }: Props) =>
15-
fill ? (
16-
<span className={clsx(styles.fullSkeleton, className)} {...props}>
17-
<Label>{label ?? "Loading"}</Label>
18-
</span>
19-
) : (
2015
<span
2116
data-fill-width={width === undefined ? "" : undefined}
2217
{...(width && { style: { "--skeleton-width": width } as CSSProperties })}
23-
className={clsx(styles.skeleton, { [className ?? ""]: fill })}
18+
className={clsx(styles.skeleton, { [styles.fullSkeleton ?? '']: fill }, { [className ?? ""]: fill })}
2419
>
2520
<span className={clsx(styles.skeletonInner, className)} {...props}>
2621
<Label>{label ?? "Loading"}</Label>
2722
</span>
2823
</span>
29-
);
3024

3125
const Label = ({ children }: { children: string | undefined }) => (
3226
<span className={styles.skeletonLabel}>{children ?? "Loading"}</span>

0 commit comments

Comments
 (0)