pyth: Print error and return 1 on mapping key failure.

Previously, pyth would return a 0 exit code but not return any data.
This could happen if the mapping key is missing or invalid.

Also, only try updating the price::pub_idx_ if the manager actually
has a publish public key. This was causing a crash when running the
tools without a publish keypair. This should be valid for running
in monitoring / consuming modes.

Author: mass

pc/request.cpp

@@ -2145,10 +2145,12 @@ void price::update_pub()
   // update publishing index
   pub_idx_ = (unsigned)-1;
   pub_key *pkey = get_manager()->get_publish_pub_key();
-  for( unsigned i=0; i != pptr_->num_; ++i ) {
-    if ( pc_pub_key_equal( &pptr_->comp_[i].pub_, (pc_pub_key_t*)pkey ) ) {
-      pub_idx_ = i;
-      break;
+  if ( pkey ) {
+    for( unsigned i=0; i != pptr_->num_; ++i ) {
+      if ( pc_pub_key_equal( &pptr_->comp_[i].pub_, (pc_pub_key_t*)pkey ) ) {
+        pub_idx_ = i;
+        break;
+      }
     }
   }
 }

pcapps/pyth.cpp

@@ -1014,6 +1014,11 @@ int on_get_product_list( int argc, char **argv )
     std::cerr << "pyth: " << mgr.get_err_msg() << std::endl;
     return 1;
   }
+  if ( !mgr.has_status( PC_PYTH_HAS_MAPPING ) ) {
+    std::cerr << "pyth: mapping not ready, check mapping key ["
+              << mgr.get_mapping_pub_key_file() << "]" << std::endl;
+    return 1;
+  }
   // list key/symbol pairs
   if ( !do_json ) {
     std::string astr;
@@ -1206,6 +1211,11 @@ int on_get_product( int argc, char **argv )
     std::cerr << "pyth: " << mgr.get_err_msg() << std::endl;
     return 1;
   }
+  if ( !mgr.has_status( PC_PYTH_HAS_MAPPING ) ) {
+    std::cerr << "pyth: mapping not ready, check mapping key ["
+              << mgr.get_mapping_pub_key_file() << "]" << std::endl;
+    return 1;
+  }
   // get product and serialize to stdout
   product *prod = mgr.get_product( pub );
   if ( !prod ) {