Support for not capturing Qt exceptions using marker or config value

Author: nicoddemus

pytestqt/_tests/test_exceptions.py

@@ -1,10 +1,12 @@
-import textwrap
 import pytest
 import sys
 from pytestqt.plugin import capture_exceptions, format_captured_exceptions
 from pytestqt.qt_compat import QtGui, Qt, QtCore
 
 
+pytest_plugins = 'pytester'
+
+
 class Receiver(QtCore.QObject):
     """
     Dummy QObject subclass that raises an error on receiving events if
@@ -45,4 +47,40 @@ def test_format_captured_exceptions():
     lines = obtained_text.splitlines()
 
     assert 'Qt exceptions in virtual methods:' in lines
-    assert 'ValueError: errors were made' in lines
+    assert 'ValueError: errors were made' in lines
+
+
+@pytest.mark.parametrize('no_capture_by_marker', [True, False])
+def test_no_capture(testdir, no_capture_by_marker):
+    """
+    Make sure options that disable exception capture are working (either marker
+    or ini configuration value).
+    :type testdir: TmpTestdir
+    """
+    if no_capture_by_marker:
+        marker_code = '@pytest.mark.qt_no_exception_capture'
+    else:
+        marker_code = ''
+        testdir.makeini('''
+            [pytest]
+            qt_no_exception_capture = 1
+        ''')
+    testdir.makepyfile('''
+        import pytest
+        from pytestqt.qt_compat import QtGui, QtCore
+
+        class MyWidget(QtGui.QWidget):
+
+            def mouseReleaseEvent(self, ev):
+                raise RuntimeError
+
+        {marker_code}
+        def test_widget(qtbot):
+            w = MyWidget()
+            qtbot.addWidget(w)
+            qtbot.mouseClick(w, QtCore.Qt.LeftButton)
+    '''.format(marker_code=marker_code))
+    result = testdir.runpytest('-s')
+    # when it fails, it fails with "1 passed, 1 error in", so ensure
+    # it is passing without errors
+    result.stdout.fnmatch_lines('*1 passed in*')

pytestqt/plugin.py

@@ -380,18 +380,34 @@ def qapp():
 
 
 @pytest.yield_fixture
-def qtbot(qapp):
+def qtbot(qapp, request):
     """
     Fixture used to create a QtBot instance for using during testing.
 
     Make sure to call addWidget for each top-level widget you create to ensure
     that they are properly closed after the test ends.
     """
     result = QtBot(qapp)
-    with capture_exceptions() as exceptions:
+    no_capture = request.node.get_marker('qt_no_exception_capture') or \
+                 request.config.getini('qt_no_exception_capture')
+    if no_capture:
         yield result
-
-    if exceptions:
-        pytest.fail(format_captured_exceptions(exceptions))
+    else:
+        with capture_exceptions() as exceptions:
+            yield result
+        if exceptions:
+            pytest.fail(format_captured_exceptions(exceptions))
 
     result._close()
+
+
+def pytest_addoption(parser):
+    parser.addini('qt_no_exception_capture',
+                  'disable automatic exception capture')
+
+
+def pytest_configure(config):
+    config.addinivalue_line(
+        'markers',
+        "qt_no_exception_capture: Disables pytest-qt's automatic exception "
+        'capture for just one test item.')