drv/bluetooth_stm32_bluenrg: Allow broadcast while connected.

Nothing happens still, but at least you can run your program to test
and debug other portions of the code that do not rely on Bluetooth.

Also update the matching notes in the BLE module and remove City Hub
limitations which have been fixed.

Author: laurensvalk

CHANGELOG.md

@@ -8,6 +8,10 @@
 - Added `MoveHub.imu.tilt()` ([support#539]).
 - Enabled hub init orientation support for Move Hub ([support#539]).
 
+### Changed
+- Allow Move Hub to ignore `broadcast` instead of raising an exception while
+  connected.
+
 ### Fixed
 - Fixed Move Hub accelerometer not working since v3.3.0b5 ([support#1269]).
 - Fixed Bluetooth chip locking up on Technic and City hubs when broadcasting ([support#1095]).

lib/pbio/drv/bluetooth/bluetooth_stm32_bluenrg.c

@@ -716,6 +716,14 @@ static PT_THREAD(broadcast_task(struct pt *pt, pbio_task_t *task)) {
 
         if (status != BLE_STATUS_SUCCESS) {
             task->status = ble_error_to_pbio_error(status);
+
+            // Broadcasting does not work while connected to the computer. But
+            // returning an error means that Move Hub programs with
+            // broadcasting can never run while connected, which makes it very
+            // impractical to test any program. So mark as success.
+            if (task->status == PBIO_ERROR_INVALID_OP) {
+                task->status = PBIO_SUCCESS;
+            }
             PT_EXIT(pt);
         }
 

pybricks/common/pb_type_ble.c

@@ -254,12 +254,9 @@ STATIC mp_obj_t pb_module_ble_broadcast(size_t n_args, const mp_obj_t *pos_args,
     PB_PARSE_ARGS_METHOD(n_args, pos_args, kw_args,
         pb_obj_BLE_t, self,
         PB_ARG_REQUIRED(data));
-    // REVISIT: disable this method on move hub and city hub?
-    // This method will raise an OSError on move hub if it is called while the
+    // On Move Hub, nothing is broadcast if it is called while the
     // move hub is connected to Pybricks Code. Also, broadcasting interferes
-    // with observing even when not connected to Pybricks Code. On the city
-    // hub, this method succeeds, but nothing is actually sent over the air.
-
+    // with observing even when not connected to Pybricks Code.
 
     // TODO: Stop broadcasting if data is None.