fix: get rid of unused clims cache (#248)

Author: tlambert03

src/ndv/controllers/_channel_controller.py

@@ -39,7 +39,6 @@ def add_lut_view(self, view: LUTView) -> None:
         """Add a LUT view to the controller."""
         view.model = self.lut_model
         self.lut_views.append(view)
-        # TODO: Could probably reuse cached clims
         self._auto_scale()
 
     def synchronize(self, *views: LUTView) -> None:
@@ -86,7 +85,7 @@ def get_value_at_index(self, idx: tuple[int, ...]) -> np.ndarray | float | None:
     def _auto_scale(self) -> None:
         if self.lut_model and len(self.handles):
             policy = self.lut_model.clims
-            handle_clims = [policy.calc_clims(handle.data()) for handle in self.handles]
+            handle_clims = [policy.get_limits(handle.data()) for handle in self.handles]
             mi, ma = handle_clims[0]
             for clims in handle_clims[1:]:
                 mi = min(mi, clims[0])

src/ndv/models/_lut_model.py

@@ -11,7 +11,6 @@
     BeforeValidator,
     ConfigDict,
     Field,
-    PrivateAttr,
     model_validator,
 )
 
@@ -26,21 +25,11 @@ class ClimPolicy(BaseModel, ABC):
     """ABC for contrast limit policies."""
 
     model_config = ConfigDict(frozen=True, extra="forbid")
-    _cached_clims: tuple[float, float] | None = PrivateAttr(None)
 
     @abstractmethod
     def get_limits(self, image: npt.NDArray) -> tuple[float, float]:
         """Return the contrast limits for the given image."""
 
-    def calc_clims(self, image: npt.NDArray) -> tuple[float, float]:
-        self._cached_clims = value = self.get_limits(image)
-        return value
-
-    @property
-    def cached_clims(self) -> tuple[float, float] | None:
-        """Return the last calculated clims."""
-        return self._cached_clims
-
     @property
     def is_manual(self) -> bool:
         return self.__class__ == ClimsManual