As discussed with Maarten, we should update the INCA precip type calculation for low level snow. The current algorithm can create an incontinuity since the 2nd condition includes a topography threshold.
The suggested change here
|
snowMask = (topoZSDiffGrid < (-1.5 * melting_layer_thickness_m)) | ((topography_grid_m <= (1.5 * melting_layer_thickness_m)) & (topoZSDiffGrid <= 0)) |
go from
snowMask = (topoZSDiffGrid < (-1.5 * melting_layer_thickness_m)) | ((topography_grid_m <= (1.5 * melting_layer_thickness_m)) & (topoZSDiffGrid <= 0))
to
snowMask = topoZSDiffGrid < (-0.5 * melting_layer_thickness_m)
We will need to update some of the tests most likely.
As discussed with Maarten, we should update the INCA precip type calculation for low level snow. The current algorithm can create an incontinuity since the 2nd condition includes a topography threshold.
The suggested change here
pysteps-diagnostic-prtype/pysteps_diagnostic_prtype/diagnostic/diagnostic_prtype.py
Line 520 in 75d8336
go from
snowMask = (topoZSDiffGrid < (-1.5 * melting_layer_thickness_m)) | ((topography_grid_m <= (1.5 * melting_layer_thickness_m)) & (topoZSDiffGrid <= 0))to
snowMask = topoZSDiffGrid < (-0.5 * melting_layer_thickness_m)We will need to update some of the tests most likely.