Include apache::mod::authn_core in every auth mod

The authn_core module is needed for AuthType, which is needed to select
a specific auth. While modules may load without them, it's unlikely to
work in practice.

This is only relevant when default mods are disabled since authn_core is
a default module.

Author: ekohl

manifests/mod/auth_basic.pp

@@ -4,5 +4,6 @@
 # @see https://httpd.apache.org/docs/current/mod/mod_auth_basic.html for additional documentation.
 #
 class apache::mod::auth_basic {
+  include apache::mod::authn_core
   ::apache::mod { 'auth_basic': }
 }

manifests/mod/auth_cas.pp

@@ -115,6 +115,7 @@
   }
 
   include apache
+  include apache::mod::authn_core
   ::apache::mod { 'auth_cas': }
 
   file { $cas_cookie_path:

manifests/mod/auth_mellon.pp

@@ -34,6 +34,7 @@
   Optional[Integer] $mellon_post_count                  = undef
 ) inherits apache::params {
   include apache
+  include apache::mod::authn_core
   ::apache::mod { 'auth_mellon': }
 
   # Template uses

manifests/mod/auth_openidc.pp

@@ -5,6 +5,7 @@
 #
 class apache::mod::auth_openidc inherits apache::params {
   include apache
+  include apache::mod::authn_core
   include apache::mod::authz_user
   apache::mod { 'auth_openidc': }
 }

spec/classes/mod/auth_cas_spec.rb

@@ -27,6 +27,7 @@
       include_examples 'Debian 11'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_cas') }
       it { is_expected.to contain_package('libapache2-mod-auth-cas') }
       it { is_expected.to contain_file('auth_cas.conf').with_path('/etc/apache2/mods-available/auth_cas.conf') }
@@ -36,6 +37,7 @@
       include_examples 'RedHat 6'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_cas') }
       it { is_expected.to contain_package('mod_auth_cas') }
       it { is_expected.to contain_file('auth_cas.conf').with_path('/etc/httpd/conf.d/auth_cas.conf') }
@@ -50,6 +52,7 @@
       include_examples 'RedHat 6'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_cas') }
       it { is_expected.to contain_package('mod_auth_cas') }
       it { is_expected.to contain_file('auth_cas.conf').with_path('/etc/httpd/conf.d/auth_cas.conf') }

spec/classes/mod/auth_gssapi_spec.rb

@@ -10,27 +10,31 @@
       include_examples 'Debian 11'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_gssapi') }
       it { is_expected.to contain_package('libapache2-mod-auth-gssapi') }
     end
     context 'on a RedHat OS', :compile do
       include_examples 'RedHat 6'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_gssapi') }
       it { is_expected.to contain_package('mod_auth_gssapi') }
     end
     context 'on a FreeBSD OS', :compile do
       include_examples 'FreeBSD 9'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_gssapi') }
       it { is_expected.to contain_package('www/mod_auth_gssapi') }
     end
     context 'on a Gentoo OS', :compile do
       include_examples 'Gentoo'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_gssapi') }
       it { is_expected.to contain_package('www-apache/mod_auth_gssapi') }
     end

spec/classes/mod/auth_kerb_spec.rb

@@ -10,27 +10,31 @@
       include_examples 'Debian 11'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_kerb') }
       it { is_expected.to contain_package('libapache2-mod-auth-kerb') }
     end
     context 'on a RedHat OS', :compile do
       include_examples 'RedHat 6'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_kerb') }
       it { is_expected.to contain_package('mod_auth_kerb') }
     end
     context 'on a FreeBSD OS', :compile do
       include_examples 'FreeBSD 9'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_kerb') }
       it { is_expected.to contain_package('www/mod_auth_kerb2') }
     end
     context 'on a Gentoo OS', :compile do
       include_examples 'Gentoo'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_kerb') }
       it { is_expected.to contain_package('www-apache/mod_auth_kerb') }
     end
@@ -49,6 +53,7 @@ class { 'apache':
         MANIFEST
       end
 
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_kerb') }
       it { is_expected.to contain_package('httpd24-mod_auth_kerb') }
       it { is_expected.not_to contain_package('mod_auth_kerb') }

spec/classes/mod/auth_mellon_spec.rb

@@ -9,6 +9,7 @@
     include_examples 'Debian 11'
 
     describe 'with no parameters' do
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_mellon') }
       it { is_expected.to contain_package('libapache2-mod-auth-mellon') }
       it { is_expected.to contain_file('auth_mellon.conf').with_path('/etc/apache2/mods-available/auth_mellon.conf') }
@@ -38,6 +39,7 @@
     include_examples 'RedHat 6'
 
     describe 'with no parameters' do
+      it { is_expected.to contain_class('apache::mod::authn_core') }
       it { is_expected.to contain_apache__mod('auth_mellon') }
       it { is_expected.to contain_package('mod_auth_mellon') }
       it { is_expected.to contain_file('auth_mellon.conf').with_path('/etc/httpd/conf.d/auth_mellon.conf') }

spec/classes/mod/auth_openidc_spec.rb

@@ -10,20 +10,26 @@
       include_examples 'Debian 11'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
+      it { is_expected.to contain_class('apache::mod::authz_user') }
       it { is_expected.to contain_apache__mod('auth_openidc') }
       it { is_expected.to contain_package('libapache2-mod-auth-openidc') }
     end
     context 'on a RedHat OS', :compile do
       include_examples 'RedHat 6'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
+      it { is_expected.to contain_class('apache::mod::authz_user') }
       it { is_expected.to contain_apache__mod('auth_openidc') }
       it { is_expected.to contain_package('mod_auth_openidc') }
     end
     context 'on a FreeBSD OS', :compile do
       include_examples 'FreeBSD 9'
 
       it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
+      it { is_expected.to contain_class('apache::mod::authz_user') }
       it { is_expected.to contain_apache__mod('auth_openidc') }
       it { is_expected.to contain_package('www/mod_auth_openidc') }
     end
@@ -42,6 +48,9 @@ class { 'apache':
         MANIFEST
       end
 
+      it { is_expected.to contain_class('apache::params') }
+      it { is_expected.to contain_class('apache::mod::authn_core') }
+      it { is_expected.to contain_class('apache::mod::authz_user') }
       it { is_expected.to contain_apache__mod('auth_openidc') }
       it { is_expected.to contain_package('httpd24-mod_auth_openidc') }
       it { is_expected.not_to contain_package('mod_auth_openidc') }