Thanks in advance for your bug report!
What happened?
This pull request made it so that right-clicking on a tab no longer adds a right-clicked class. The author notes that they regarded this behavior to be “unused,” but the Zentabs package relies on this behavior for its “Pin tab” and “Unpin tab” commands. It uses .right-clicked to identify which tab was right-clicked and trace it back to its associated editor pane.
I'm treating this as a bug because Pulsar allows a package to add commands to a tab's context menu, which means that those commands need some way to figure out which tab they were invoked from. There's no other obvious way that I can see, and if Pulsar restores the .right-clicked behavior, it will fix Zentabs (and other packages, probably) without their needing to push out an update.
I will be happy to contribute this fix myself if need be, but I'm opening this issue because I've not yet set up my local environment to do so.
Pulsar version
1.101.0-beta
Which OS does this happen on?
🍎 macOS
OS details
11.7.2
Which CPU architecture are you running this on?
64-bit(x86_64)
What steps are needed to reproduce this?
- Open the inspector and inspect a tab element.
- Right-click on that tab.
- Observe that no classes are added to the
li element that represents the tab.
Additional Information:
No response
Thanks in advance for your bug report!
What happened?
This pull request made it so that right-clicking on a tab no longer adds a
right-clickedclass. The author notes that they regarded this behavior to be “unused,” but the Zentabs package relies on this behavior for its “Pin tab” and “Unpin tab” commands. It uses.right-clickedto identify which tab was right-clicked and trace it back to its associated editor pane.I'm treating this as a bug because Pulsar allows a package to add commands to a tab's context menu, which means that those commands need some way to figure out which tab they were invoked from. There's no other obvious way that I can see, and if Pulsar restores the
.right-clickedbehavior, it will fix Zentabs (and other packages, probably) without their needing to push out an update.I will be happy to contribute this fix myself if need be, but I'm opening this issue because I've not yet set up my local environment to do so.
Pulsar version
1.101.0-beta
Which OS does this happen on?
🍎 macOS
OS details
11.7.2
Which CPU architecture are you running this on?
64-bit(x86_64)
What steps are needed to reproduce this?
lielement that represents the tab.Additional Information:
No response