From d61b9ec258c3bf9f41980eb6a4c52ff104ed0e0b Mon Sep 17 00:00:00 2001
From: Marcin Czarkowski <wilsonowy@gmail.com>
Date: Mon, 22 Sep 2025 14:24:52 +0200
Subject: [PATCH] test: cover useKeyboardActivation hook

---
 src/components/rule-builder/LibraryItem.tsx   | 11 +--
 src/components/rule-builder/SearchInput.tsx   | 15 ++--
 src/components/rule-builder/SelectedRules.tsx | 18 +++--
 .../rule-collections/CollectionListEntry.tsx  | 45 +++++++----
 src/components/ui/Accordion.tsx               | 11 +--
 src/hooks/useKeyboardActivation.ts            | 46 +++++++++++
 tests/hooks/useKeyboardActivation.test.tsx    | 76 +++++++++++++++++++
 tests/setup/types.d.ts                        |  2 +-
 tests/setup/vitest.setup.ts                   |  2 +-
 9 files changed, 179 insertions(+), 47 deletions(-)
 create mode 100644 src/hooks/useKeyboardActivation.ts
 create mode 100644 tests/hooks/useKeyboardActivation.test.tsx

diff --git a/src/components/rule-builder/LibraryItem.tsx b/src/components/rule-builder/LibraryItem.tsx
index d4df935..dffa651 100644
--- a/src/components/rule-builder/LibraryItem.tsx
+++ b/src/components/rule-builder/LibraryItem.tsx
@@ -1,11 +1,11 @@
 import { Check } from 'lucide-react';
-import type { KeyboardEvent } from 'react';
 import React from 'react';
 import { Library } from '../../data/dictionaries';
 import { getLibraryTranslation } from '../../i18n/translations';
 import type { LayerType } from '../../styles/theme';
 import { getLayerClasses } from '../../styles/theme';
 import { useAccordionContentOpen } from '../ui/Accordion';
+import { useKeyboardActivation } from '../../hooks/useKeyboardActivation';
 
 interface LibraryItemProps {
   library: Library;
@@ -19,12 +19,9 @@ export const LibraryItem: React.FC<LibraryItemProps> = React.memo(
     const isParentAccordionOpen = useAccordionContentOpen();
     const itemClasses = getLayerClasses.libraryItem(layerType, isSelected);
 
-    const handleKeyDown = (e: KeyboardEvent<HTMLButtonElement>) => {
-      if (e.key === 'Enter' || e.key === ' ') {
-        e.preventDefault();
-        onToggle(library);
-      }
-    };
+    const handleKeyDown = useKeyboardActivation<HTMLButtonElement>(() => {
+      onToggle(library);
+    });
 
     return (
       <button
diff --git a/src/components/rule-builder/SearchInput.tsx b/src/components/rule-builder/SearchInput.tsx
index 0bbedeb..13fd942 100644
--- a/src/components/rule-builder/SearchInput.tsx
+++ b/src/components/rule-builder/SearchInput.tsx
@@ -1,6 +1,7 @@
 import { Search, X } from 'lucide-react';
-import type { ChangeEvent, KeyboardEvent } from 'react';
+import type { ChangeEvent } from 'react';
 import React, { useCallback, useRef, useState } from 'react';
+import { useKeyboardActivation } from '../../hooks/useKeyboardActivation';
 
 interface SearchInputProps {
   searchQuery: string;
@@ -32,15 +33,9 @@ export const SearchInput: React.FC<SearchInputProps> = ({
     inputRef.current?.focus();
   }, [setSearchQuery]);
 
-  const handleKeyDown = useCallback(
-    (e: KeyboardEvent<HTMLButtonElement>) => {
-      if (e.key === 'Enter' || e.key === ' ') {
-        e.preventDefault();
-        handleClear();
-      }
-    },
-    [handleClear],
-  );
+  const handleKeyDown = useKeyboardActivation<HTMLButtonElement>(() => {
+    handleClear();
+  });
 
   return (
     <div
diff --git a/src/components/rule-builder/SelectedRules.tsx b/src/components/rule-builder/SelectedRules.tsx
index 6a733d2..b991ff9 100644
--- a/src/components/rule-builder/SelectedRules.tsx
+++ b/src/components/rule-builder/SelectedRules.tsx
@@ -1,9 +1,9 @@
 import { X } from 'lucide-react';
 import React from 'react';
-import type { KeyboardEvent } from 'react';
 import { Library } from '../../data/dictionaries';
 import type { LayerType } from '../../styles/theme';
 import { getLayerClasses } from '../../styles/theme';
+import { useKeyboardActivation } from '../../hooks/useKeyboardActivation';
 
 interface SelectedRulesProps {
   selectedLibraries: Library[];
@@ -13,12 +13,15 @@ interface SelectedRulesProps {
 
 export const SelectedRules: React.FC<SelectedRulesProps> = React.memo(
   ({ selectedLibraries, unselectLibrary, getLibraryLayerType }) => {
-    const handleKeyDown = (e: KeyboardEvent<HTMLButtonElement>, library: Library) => {
-      if (e.key === 'Enter' || e.key === ' ') {
-        e.preventDefault();
-        unselectLibrary(library);
+    const handleRemoveKeyDown = useKeyboardActivation<HTMLButtonElement>((event) => {
+      const library = event.currentTarget.dataset.library as Library | undefined;
+
+      if (!library) {
+        return;
       }
-    };
+
+      unselectLibrary(library);
+    });
 
     if (selectedLibraries.length === 0) {
       return null;
@@ -42,8 +45,9 @@ export const SelectedRules: React.FC<SelectedRulesProps> = React.memo(
               >
                 <span>{library}</span>
                 <button
+                  data-library={library}
                   onClick={() => unselectLibrary(library)}
-                  onKeyDown={(e) => handleKeyDown(e, library)}
+                  onKeyDown={handleRemoveKeyDown}
                   className={`text-white opacity-70 cursor-pointer hover:opacity-100 focus:outline-none focus:ring-2 focus:ring-offset-1 ${getLayerClasses.focusRing(layerType)}`}
                   aria-label={`Remove ${library} rule`}
                   tabIndex={0}
diff --git a/src/components/rule-collections/CollectionListEntry.tsx b/src/components/rule-collections/CollectionListEntry.tsx
index ef52068..82aff8c 100644
--- a/src/components/rule-collections/CollectionListEntry.tsx
+++ b/src/components/rule-collections/CollectionListEntry.tsx
@@ -4,6 +4,7 @@ import type { Collection } from '../../store/collectionsStore';
 import { useCollectionsStore } from '../../store/collectionsStore';
 import DeletionDialog from './DeletionDialog';
 import SaveCollectionDialog from './SaveCollectionDialog';
+import { useKeyboardActivation } from '../../hooks/useKeyboardActivation';
 
 interface CollectionListEntryProps {
   collection: Collection;
@@ -29,9 +30,13 @@ export const CollectionListEntry: React.FC<CollectionListEntryProps> = ({
     onClick?.(collection);
   };
 
+  const openDeleteDialog = () => {
+    setIsDeleteDialogOpen(true);
+  };
+
   const handleDeleteClick = (e: React.MouseEvent) => {
     e.stopPropagation();
-    setIsDeleteDialogOpen(true);
+    openDeleteDialog();
   };
 
   const handleSaveClick = async (e: React.MouseEvent) => {
@@ -60,11 +65,33 @@ export const CollectionListEntry: React.FC<CollectionListEntryProps> = ({
     }
   };
 
+  const openEditDialog = () => {
+    setIsEditDialogOpen(true);
+  };
+
   const handleEditClick = (e: React.MouseEvent) => {
     e.stopPropagation();
-    setIsEditDialogOpen(true);
+    openEditDialog();
   };
 
+  const handleEditKeyDown = useKeyboardActivation<HTMLDivElement>(
+    () => {
+      openEditDialog();
+    },
+    {
+      stopPropagation: true,
+    },
+  );
+
+  const handleDeleteKeyDown = useKeyboardActivation<HTMLDivElement>(
+    () => {
+      openDeleteDialog();
+    },
+    {
+      stopPropagation: true,
+    },
+  );
+
   const handleEditSave = async (name: string, description: string) => {
     try {
       await updateCollection(collection.id, { ...collection, name, description });
@@ -101,12 +128,7 @@ export const CollectionListEntry: React.FC<CollectionListEntryProps> = ({
               tabIndex={0}
               className="p-1.5 rounded-md text-gray-400 hover:text-blue-400 hover:bg-gray-700/50 opacity-0 group-hover:opacity-100 transition-colors cursor-pointer"
               aria-label={`Edit ${collection.name}`}
-              onKeyDown={(e) => {
-                if (e.key === 'Enter' || e.key === ' ') {
-                  e.preventDefault();
-                  handleEditClick(e as unknown as React.MouseEvent);
-                }
-              }}
+              onKeyDown={handleEditKeyDown}
             >
               <Pencil className="size-4" />
             </div>
@@ -117,12 +139,7 @@ export const CollectionListEntry: React.FC<CollectionListEntryProps> = ({
               tabIndex={0}
               className="p-1.5 rounded-md text-gray-400 hover:text-red-400 hover:bg-gray-700/50 opacity-0 group-hover:opacity-100 cursor-pointer transition-colors"
               aria-label={`Delete ${collection.name}`}
-              onKeyDown={(e) => {
-                if (e.key === 'Enter' || e.key === ' ') {
-                  e.preventDefault();
-                  handleDeleteClick(e as unknown as React.MouseEvent);
-                }
-              }}
+              onKeyDown={handleDeleteKeyDown}
             >
               <Trash2 className="size-4" />
             </div>
diff --git a/src/components/ui/Accordion.tsx b/src/components/ui/Accordion.tsx
index 426b398..7e503fc 100644
--- a/src/components/ui/Accordion.tsx
+++ b/src/components/ui/Accordion.tsx
@@ -1,7 +1,7 @@
 import { ChevronDown } from 'lucide-react';
-import type { KeyboardEvent } from 'react';
 import React, { createContext, useContext } from 'react';
 import { transitions } from '../../styles/theme';
+import { useKeyboardActivation } from '../../hooks/useKeyboardActivation';
 
 // Create a context to track accordion open state
 const AccordionContentContext = createContext<boolean>(false);
@@ -67,12 +67,9 @@ export const AccordionTrigger: React.FC<AccordionTriggerProps> = React.memo(
     // Only nested triggers should check parent state
     const shouldBeFocusable = isRoot || isParentAccordionOpen;
 
-    const handleKeyDown = (e: KeyboardEvent<HTMLDivElement>) => {
-      if (e.key === 'Enter' || e.key === ' ') {
-        e.preventDefault();
-        onClick?.();
-      }
-    };
+    const handleKeyDown = useKeyboardActivation<HTMLDivElement>(() => {
+      onClick?.();
+    });
 
     return (
       <div
diff --git a/src/hooks/useKeyboardActivation.ts b/src/hooks/useKeyboardActivation.ts
new file mode 100644
index 0000000..53ab14b
--- /dev/null
+++ b/src/hooks/useKeyboardActivation.ts
@@ -0,0 +1,46 @@
+import { useCallback, useMemo } from 'react';
+import type { KeyboardEvent, KeyboardEventHandler } from 'react';
+
+type ActivationKey = 'Enter' | ' ' | 'Space' | 'Spacebar';
+
+interface UseKeyboardActivationOptions {
+  keys?: ReadonlyArray<ActivationKey>;
+  preventDefault?: boolean;
+  stopPropagation?: boolean;
+}
+
+const DEFAULT_ACTIVATION_KEYS: ReadonlyArray<ActivationKey> = ['Enter', ' ', 'Space', 'Spacebar'];
+
+export const useKeyboardActivation = <T extends HTMLElement>(
+  onActivate: (event: KeyboardEvent<T>) => void,
+  options: UseKeyboardActivationOptions = {},
+): KeyboardEventHandler<T> => {
+  const {
+    keys = DEFAULT_ACTIVATION_KEYS,
+    preventDefault = true,
+    stopPropagation = false,
+  } = options;
+
+  const keySet = useMemo(() => new Set(keys), [keys]);
+
+  return useCallback<KeyboardEventHandler<T>>(
+    (event) => {
+      if (!keySet.has(event.key as ActivationKey)) {
+        return;
+      }
+
+      if (preventDefault) {
+        event.preventDefault();
+      }
+
+      if (stopPropagation) {
+        event.stopPropagation();
+      }
+
+      onActivate(event);
+    },
+    [keySet, onActivate, preventDefault, stopPropagation],
+  );
+};
+
+export default useKeyboardActivation;
diff --git a/tests/hooks/useKeyboardActivation.test.tsx b/tests/hooks/useKeyboardActivation.test.tsx
new file mode 100644
index 0000000..75b9a14
--- /dev/null
+++ b/tests/hooks/useKeyboardActivation.test.tsx
@@ -0,0 +1,76 @@
+import { renderHook } from '@testing-library/react';
+import type { KeyboardEvent } from 'react';
+import { describe, expect, it, vi } from 'vitest';
+
+import useKeyboardActivation from '@/hooks/useKeyboardActivation';
+
+type EventFactoryResult = {
+  event: KeyboardEvent<HTMLElement>;
+  preventDefault: ReturnType<typeof vi.fn>;
+  stopPropagation: ReturnType<typeof vi.fn>;
+};
+
+const createKeyboardEvent = (key: string): EventFactoryResult => {
+  const preventDefault = vi.fn();
+  const stopPropagation = vi.fn();
+
+  const event = {
+    key,
+    preventDefault,
+    stopPropagation,
+  } as unknown as KeyboardEvent<HTMLElement>;
+
+  return { event, preventDefault, stopPropagation };
+};
+
+describe('useKeyboardActivation', () => {
+  it('invokes the provided callback when an activation key is pressed', () => {
+    const onActivate = vi.fn();
+    const { result } = renderHook(() => useKeyboardActivation(onActivate));
+    const { event, preventDefault, stopPropagation } = createKeyboardEvent('Enter');
+
+    result.current(event);
+
+    expect(onActivate).toHaveBeenCalledWith(event);
+    expect(preventDefault).toHaveBeenCalledTimes(1);
+    expect(stopPropagation).not.toHaveBeenCalled();
+  });
+
+  it('ignores keys that are not configured as activation keys', () => {
+    const onActivate = vi.fn();
+    const { result } = renderHook(() => useKeyboardActivation(onActivate));
+    const { event, preventDefault, stopPropagation } = createKeyboardEvent('Escape');
+
+    result.current(event);
+
+    expect(onActivate).not.toHaveBeenCalled();
+    expect(preventDefault).not.toHaveBeenCalled();
+    expect(stopPropagation).not.toHaveBeenCalled();
+  });
+
+  it('respects the preventDefault option', () => {
+    const onActivate = vi.fn();
+    const { result } = renderHook(() =>
+      useKeyboardActivation(onActivate, { preventDefault: false }),
+    );
+    const { event, preventDefault } = createKeyboardEvent('Enter');
+
+    result.current(event);
+
+    expect(onActivate).toHaveBeenCalledWith(event);
+    expect(preventDefault).not.toHaveBeenCalled();
+  });
+
+  it('calls stopPropagation when configured', () => {
+    const onActivate = vi.fn();
+    const { result } = renderHook(() =>
+      useKeyboardActivation(onActivate, { stopPropagation: true }),
+    );
+    const { event, stopPropagation } = createKeyboardEvent('Enter');
+
+    result.current(event);
+
+    expect(onActivate).toHaveBeenCalledWith(event);
+    expect(stopPropagation).toHaveBeenCalledTimes(1);
+  });
+});
diff --git a/tests/setup/types.d.ts b/tests/setup/types.d.ts
index 97e5a5e..0595a64 100644
--- a/tests/setup/types.d.ts
+++ b/tests/setup/types.d.ts
@@ -1,4 +1,4 @@
-import '@testing-library/jest-dom';
+import '@testing-library/jest-dom/vitest';
 
 declare module 'vitest' {
   // interface Assertion<T = any> extends jest.Matchers<void, T> {}
diff --git a/tests/setup/vitest.setup.ts b/tests/setup/vitest.setup.ts
index 875d728..1b16640 100644
--- a/tests/setup/vitest.setup.ts
+++ b/tests/setup/vitest.setup.ts
@@ -1,4 +1,4 @@
-import '@testing-library/jest-dom';
+import '@testing-library/jest-dom/vitest';
 import { afterAll, afterEach, beforeAll, vi } from 'vitest';
 import { setupServer } from 'msw/node';
 import { cleanup } from '@testing-library/react';