Skip to content

Commit cb493b9

Browse files
committed
remove 8
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
1 parent d9df6eb commit cb493b9

1 file changed

Lines changed: 15 additions & 16 deletions

File tree

.github/workflows/java-version-matrix-tests.yml

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ jobs:
2323
strategy:
2424
fail-fast: false
2525
matrix:
26-
java-version: [8, 11, 17, 21, 25]
26+
# Note: Java 8 runtime testing is skipped due to Spotless incompatibility
27+
java-version: [11, 17, 21, 25]
2728
steps:
2829
- name: Check out
2930
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -47,25 +48,23 @@ jobs:
4748
- name: Build core library artifacts
4849
run: mise exec -- ./mvnw install -DskipTests -Dspotless.check.skip=true -Dcoverage.skip=true -Dcheckstyle.skip=true -Dwarnings=-nowarn -pl '!integration-tests'
4950

50-
- name: Clean and rebuild sample apps targeting Java ${{ matrix.java-version }}
51+
- name: Install integration-tests parent POM
5152
run: |
5253
cd integration-tests
53-
if [ "${{ matrix.java-version }}" = "8" ]; then
54-
# Java 8 doesn't support --release flag, use source/target instead
55-
mise exec -- ../mvnw clean install -DskipTests -Dspotless.check.skip=true -Dcoverage.skip=true -Dcheckstyle.skip=true -Dwarnings=-nowarn \
56-
-Djava.version=8 \
57-
-Dmaven.compiler.source=8 \
58-
-Dmaven.compiler.target=8
59-
else
60-
# Java 9+ supports --release flag for better compatibility
61-
mise exec -- ../mvnw clean install -DskipTests -Dspotless.check.skip=true -Dcoverage.skip=true -Dcheckstyle.skip=true -Dwarnings=-nowarn \
62-
-Djava.version=${{ matrix.java-version }} \
63-
-Dmaven.compiler.release=${{ matrix.java-version }}
64-
fi
54+
mise exec -- ../mvnw clean install -N -Dspotless.skip=true
6555
66-
- name: Run integration tests in parallel
56+
- name: Rebuild sample apps targeting Java ${{ matrix.java-version }}
57+
run: |
58+
cd integration-tests
59+
mise exec -- ../mvnw install -DskipTests -Dspotless.skip=true -Dcoverage.skip=true -Dcheckstyle.skip=true -Dwarnings=-nowarn \
60+
-Djava.version=${{ matrix.java-version }} \
61+
-Dmaven.compiler.release=${{ matrix.java-version }} \
62+
-pl it-common,it-exporter,it-pushgateway
63+
64+
- name: Run integration tests
6765
env:
6866
TEST_JAVA_VERSION: ${{ matrix.java-version }}
6967
run: |
7068
cd integration-tests
71-
mise exec -- ../mvnw verify -T 2C -Dspotless.check.skip=true -Dcoverage.skip=true -Dcheckstyle.skip=true -Dwarnings=-nowarn
69+
mise exec -- ../mvnw verify -T 2C -Dspotless.skip=true -Dcoverage.skip=true -Dcheckstyle.skip=true -Dwarnings=-nowarn \
70+
-pl it-exporter,it-pushgateway

0 commit comments

Comments
 (0)