Fixed Filenames for Various Gen 7 Events#563
Open
ScarlettHaze wants to merge 2 commits intoprojectpokemon:masterfrom
Open
Fixed Filenames for Various Gen 7 Events#563ScarlettHaze wants to merge 2 commits intoprojectpokemon:masterfrom
ScarlettHaze wants to merge 2 commits intoprojectpokemon:masterfrom
Conversation
Fixed duplicate and mislabeled .wc7full files where the first byte header did not match the file name or game version and removed a duplicate Celebi event file
Member
|
I haven't merged this yet cause I want to see if I can look up some notes (I don't have many), regarding how we got these files, whether they were direct from the servers, or not. Believe it or not, back in Gen 6/7, wondercards were distributed to specific versions, but their card data didn't match. There were often mistakes. EDIT: @ScarlettHaze - see here: This indicates what happened, there was a mistake, and it was supposed to be infinite redemption, but SM got a card without it for a while. So we have both. The SM on the file name represents who received it, not what versions the card claims could be redeemed. |
… USUM - ウバメ Celebi (Single Redeem) (JPN).wc7full
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes duplicate and mislabeled .wc7full files where the first byte header (Receiving Version) does not match the file name or game version.
0251 SM - ウバメ Celebi (JPN).wc7full
0251 USUM - ウバメ Celebi (Infinite Redeem) (JPN).wc7full
These two files are byte-for-byte identical.
The first byte (0F) indicates SMUSUM, not just SM or USUM individually.
So I removed one of the files and renamed them to SMUSUM.