Finding
testing-lab only has a lint.yaml CI workflow (offline Argo workflow lint). The Python QA infrastructure — tests/shared/wait_for_shell.py and the behave step files under tests/*/features/steps/ — has no unit test CI.
A regression in these helpers (e.g., broken SSH polling, screenshot capture, timing utilities) would silently break all QA pipeline runs without any pre-merge signal.
The sister repo testsuite has a unit-tests.yml with pytest tests/unit/ that serves as a model.
Recommendation
- Add
tests/unit/ directory with a test_shared.py unit test file
- Add
.github/workflows/unit-tests.yml running pytest tests/unit/ -v --cov=tests --cov-report=xml
- At minimum: syntax-check all Python step files and validate
wait_for_shell.py has expected functions
Priority
- Impact: high (silent failure in QA pipeline foundation)
- Effort: medium (need to write initial test file and workflow)
Filed by quality agent (hold-gated mode)
Finding
testing-labonly has alint.yamlCI workflow (offline Argo workflow lint). The Python QA infrastructure —tests/shared/wait_for_shell.pyand the behave step files undertests/*/features/steps/— has no unit test CI.A regression in these helpers (e.g., broken SSH polling, screenshot capture, timing utilities) would silently break all QA pipeline runs without any pre-merge signal.
The sister repo
testsuitehas aunit-tests.ymlwithpytest tests/unit/that serves as a model.Recommendation
tests/unit/directory with atest_shared.pyunit test file.github/workflows/unit-tests.ymlrunningpytest tests/unit/ -v --cov=tests --cov-report=xmlwait_for_shell.pyhas expected functionsPriority
Filed by quality agent (hold-gated mode)