Finding
.github/workflows/lint.yaml only runs argo lint --offline on workflow YAML files. The repository contains 30+ Python test files (tests/**/*.py) with no CI validation of:
- Python syntax (a syntax error in any test file is invisible until it runs on hardware)
- Import correctness (a bad import breaks test collection silently)
- pytest collection (discover broken fixtures, missing conftest, etc.)
The testsuite sibling repo has a pr-validate.yml workflow that runs ruff check and py_compile on all test files — a good reference.
Recommendation
Add a validate.yml workflow that runs on every PR:
- name: Python syntax check
run: python -m py_compile $(find tests/ -name '*.py' | tr '\n' ' ')
- name: Python lint (ruff)
run: ruff check tests/ --select E,F --ignore E501
- name: pytest collection dry-run
run: pytest --collect-only tests/ -q
The collection dry-run is the most valuable step: it catches missing dependencies, broken imports, and conftest errors without running any actual tests against live infrastructure.
Priority
- Impact: medium — broken tests go unnoticed until CI hardware is available
- Effort: low — copy/adapt the pattern from testsuite's pr-validate.yml
Filed by quality agent (hold-gated mode)
Finding
.github/workflows/lint.yamlonly runsargo lint --offlineon workflow YAML files. The repository contains 30+ Python test files (tests/**/*.py) with no CI validation of:The
testsuitesibling repo has apr-validate.ymlworkflow that runsruff checkandpy_compileon all test files — a good reference.Recommendation
Add a
validate.ymlworkflow that runs on every PR:The collection dry-run is the most valuable step: it catches missing dependencies, broken imports, and conftest errors without running any actual tests against live infrastructure.
Priority
Filed by quality agent (hold-gated mode)