Skip to content

Commit 6e3479b

Browse files
committed
Fix installed pkgconfig files using wrong linker argument
for some unknown reason I used "-l:<lib>" in the .pc files while it should just be "-l<lib>". This would prevent libprojectM (and the playlist lib) from being linked in projects using pkgconfig.
1 parent 3158ee6 commit 6e3479b

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

cmake/GeneratePkgConfigFiles.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ macro(GENERATE_PKG_CONFIG_FILES target package_name)
2323
endforeach()
2424
endif()
2525

26-
# Get name for "-l:<name>" linker flags
26+
# Get name for "-l<name>" linker flags
2727
get_target_property(_lib_name ${target} OUTPUT_NAME)
2828

2929
# Using different package name for debug and release, as pkg-config doesn't support

cmake/pkgconfig-file.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ Name: @PKGCONFIG_PACKAGE_NAME@
99
Version: @PROJECT_VERSION@
1010
Description: @PKGCONFIG_PACKAGE_DESCRIPTION@
1111
Requires: @PKGCONFIG_PACKAGE_REQUIREMENTS@
12-
Libs: -L${libdir} -l:@PKGCONFIG_PROJECTM_LIBRARY@ @PKGCONFIG_LIBS@
12+
Libs: -L${libdir} -l@PKGCONFIG_PROJECTM_LIBRARY@ @PKGCONFIG_LIBS@
1313
Cflags: -I${includedir} @PKGCONFIG_FLAGS@

src/libprojectM/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ if(ENABLE_INSTALL)
207207
# into pkgconfig's expected format.
208208
# We will just assume the build uses Boost from the default location (e.g. not a custom CMAKE_PREFIX_PATH) and
209209
# the library name is correct.
210-
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -l:boost_filesystem")
210+
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -lboost_filesystem")
211211
endif()
212212

213213
set(PKGCONFIG_PACKAGE_NAME "${PROJECTM_LIBRARY_BASE_OUTPUT_NAME}")

src/playlist/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ if(ENABLE_INSTALL)
154154
# into pkgconfig's expected format.
155155
# We will just assume the build uses Boost from the default location (e.g. not a custom CMAKE_PREFIX_PATH) and
156156
# the library name is correct.
157-
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -l:boost_filesystem")
157+
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -lboost_filesystem")
158158
endif()
159159

160160
set(PKGCONFIG_PACKAGE_NAME "${PROJECTM_LIBRARY_BASE_OUTPUT_NAME}-playlist")

0 commit comments

Comments
 (0)