fix: Bind klog flags to CLI options

Author: astefanutti

cmd/kar-controllers/app/options/options.go

@@ -32,7 +32,6 @@ package options
 
 import (
 	"flag"
-	klog "k8s.io/klog/v2"
 	"os"
 	"strconv"
 	"strings"
@@ -51,10 +50,10 @@ type ServerOption struct {
 	BackoffTime     int  // Number of seconds a job will go away for, if it can not be scheduled.  Default is 20.
 	// Head of line job will not be bumped away for at least HeadOfLineHoldingTime seconds by higher priority jobs.
 	// Default setting to 0 disables this mechanism.
-	HeadOfLineHoldingTime int
-	QuotaEnabled          bool	// Controller is to evaluate quota per request
-	QuotaRestURL          string
-	HealthProbeListenAddr string
+	HeadOfLineHoldingTime              int
+	QuotaEnabled                       bool // Controller is to evaluate quota per request
+	QuotaRestURL                       string
+	HealthProbeListenAddr              string
 	DispatchResourceReservationTimeout int64
 }
 
@@ -78,13 +77,11 @@ func (s *ServerOption) AddFlags(fs *flag.FlagSet) {
 	fs.BoolVar(&s.Preemption, "preemption", s.Preemption, "Set controller to allow preemption if set to true. Note: when set to true, the Kubernetes Scheduler must be configured to enable preemption.  Default is false.")
 	fs.IntVar(&s.BackoffTime, "backofftime", s.BackoffTime, "Number of seconds a job will go away for, if it can not be scheduled.  Default is 20.")
 	fs.IntVar(&s.HeadOfLineHoldingTime, "headoflineholdingtime", s.HeadOfLineHoldingTime, "Number of seconds a job can stay at the Head Of Line without being bumped.  Default is 0.")
-	fs.BoolVar(&s.QuotaEnabled,"quotaEnabled", s.QuotaEnabled,"Enable quota policy evaluation.  Default is false.")
+	fs.BoolVar(&s.QuotaEnabled, "quotaEnabled", s.QuotaEnabled, "Enable quota policy evaluation.  Default is false.")
 	fs.StringVar(&s.QuotaRestURL, "quotaURL", s.QuotaRestURL, "URL for ReST quota management.  Default is none.")
 	fs.IntVar(&s.SecurePort, "secure-port", 6443, "The port on which to serve secured, authenticated access for metrics.")
 	fs.StringVar(&s.HealthProbeListenAddr, "healthProbeListenAddr", ":8081", "Listen address for health probes. Defaults to ':8081'")
 	fs.Int64Var(&s.DispatchResourceReservationTimeout, "dispatchResourceReservationTimeout", s.DispatchResourceReservationTimeout, "Resource reservation timeout for pods to be created once AppWrapper is dispatched, in millisecond.  Defaults to '300000', 5 minutes")
-	flag.Parse()
-	klog.V(4).Infof("[AddFlags] Controller configuration: %#v", s)
 }
 
 func (s *ServerOption) loadDefaultsFromEnvVars() {
@@ -148,7 +145,3 @@ func (s *ServerOption) loadDefaultsFromEnvVars() {
 		}
 	}
 }
-
-func (s *ServerOption) CheckOptionOrDie() {
-
-}

cmd/kar-controllers/main.go

@@ -33,21 +33,21 @@ package main
 import (
 	"flag"
 	"fmt"
+	"os"
+
+	"k8s.io/klog/v2"
 
 	"github.com/project-codeflare/multi-cluster-app-dispatcher/cmd/kar-controllers/app"
 	"github.com/project-codeflare/multi-cluster-app-dispatcher/cmd/kar-controllers/app/options"
-
-	"os"
 )
 
 func main() {
-	//flag.Parse()
-
 	s := options.NewServerOption()
-	s.AddFlags(flag.CommandLine)
 
-	//	flag.InitFlags()
-	s.CheckOptionOrDie()
+	flagSet := flag.CommandLine
+	klog.InitFlags(flagSet)
+	s.AddFlags(flagSet)
+	flag.Parse()
 
 	if err := app.Run(s); err != nil {
 		fmt.Fprintf(os.Stderr, "%v\n", err)