test: Print MNIST batch job logs

Author: astefanutti

test/e2e/mnist_pytorch_mcad_job_test.go

@@ -25,6 +25,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/labels"
 
 	. "github.com/project-codeflare/codeflare-operator/test/support"
 	mcadv1beta1 "github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/apis/controller/v1beta1"
@@ -179,4 +180,16 @@ torchvision==0.12.0
 
 	test.Eventually(Job(test, namespace, job.Name), TestTimeoutLong).
 		Should(WithTransform(ConditionStatus(batchv1.JobComplete), Equal(corev1.ConditionTrue)))
+
+	// Refresh the job to get the generated pod selector
+	job = GetJob(test, namespace, job.Name)
+
+	// Get the job Pod
+	pods := GetPods(test, namespace, metav1.ListOptions{
+		LabelSelector: labels.FormatLabels(job.Spec.Selector.MatchLabels)},
+	)
+	test.Expect(pods).To(HaveLen(1))
+
+	// Print the job logs
+	test.T().Log(GetPodLogs(test, &pods[0], corev1.PodLogOptions{}))
 }

test/support/batch.go

@@ -31,3 +31,8 @@ func Job(t Test, namespace *corev1.Namespace, name string) func(g gomega.Gomega)
 		return job
 	}
 }
+
+func GetJob(t Test, namespace *corev1.Namespace, name string) *batchv1.Job {
+	t.T().Helper()
+	return Job(t, namespace, name)(t)
+}

test/support/core.go

@@ -18,8 +18,12 @@ package support
 
 import (
 	"encoding/json"
+	"io"
 
 	"github.com/onsi/gomega"
+
+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 )
 
@@ -31,3 +35,25 @@ func Raw(t Test, obj runtime.Object) runtime.RawExtension {
 		Raw: data,
 	}
 }
+
+func GetPods(t Test, namespace *corev1.Namespace, options metav1.ListOptions) []corev1.Pod {
+	t.T().Helper()
+	pods, err := t.Client().Core().CoreV1().Pods(namespace.Name).List(t.Ctx(), options)
+	t.Expect(err).NotTo(gomega.HaveOccurred())
+	return pods.Items
+}
+
+func GetPodLogs(t Test, pod *corev1.Pod, options corev1.PodLogOptions) string {
+	t.T().Helper()
+	stream, err := t.Client().Core().CoreV1().Pods(pod.GetNamespace()).GetLogs(pod.GetName(), &options).Stream(t.Ctx())
+	t.Expect(err).NotTo(gomega.HaveOccurred())
+
+	defer func() {
+		t.Expect(stream.Close()).To(gomega.Succeed())
+	}()
+
+	bytes, err := io.ReadAll(stream)
+	t.Expect(err).NotTo(gomega.HaveOccurred())
+
+	return string(bytes)
+}