style(ui): replace let/var with const for never-reassigned variables

3xp0rt · 3xp0rt · commit 5f0ad7dc80bd · 2026-02-13T03:24:17.000+02:00
diff --git a/ui/src/components/domain/activity/Activity.tsx b/ui/src/components/domain/activity/Activity.tsx
@@ -148,13 +148,13 @@ export default function Activity({ log }: ActivityProps) {
     const formatDiff = (diffTxt: string) => {
         if (!diffTxt) return '';
 
-        let dmp = new diff_match_patch();
-        let patch = dmp.patch_fromText(diffTxt);
+        const dmp = new diff_match_patch();
+        const patch = dmp.patch_fromText(diffTxt);
         if (!patch || patch.length === 0) {
             return '<span class="text-muted-foreground">No changes</span>';
         }
         // Type assertion needed because diff-match-patch types are incomplete
-        let html = diff_prettyDiffLines((patch[0] as any).diffs);
+        const html = diff_prettyDiffLines((patch[0] as any).diffs);
         return html;
     };
 
diff --git a/ui/src/components/domain/enrichment/EnrichmentRequestsList.tsx b/ui/src/components/domain/enrichment/EnrichmentRequestsList.tsx
@@ -208,19 +208,19 @@ function EnrichmentRequestsList({
     );
 
     const errorMsg = (request: EnrichmentRequest) => {
-        let msgs: string[] = [];
+        const msgs: string[] = [];
         if (request.ignoredCount && request.ignoredCount > 0) {
             msgs.push(
                 `Ignored ${request.ignoredCount} artifact${request.ignoredCount > 1 ? 's' : ''}`,
             );
         }
-        let warn_count =
+        const warn_count =
             request.enrichers?.filter((enricher) => enricher.status === 'warning')
                 .length || 0;
         if (warn_count > 0) {
             msgs.push(`Warnings in ${warn_count} enricher${warn_count > 1 ? 's' : ''}`);
         }
-        let error_count =
+        const error_count =
             request.enrichers?.filter((enricher) => enricher.status === 'error')
                 .length || 0;
         if (error_count > 0) {
diff --git a/ui/src/components/domain/enrichment/EnrichmentResults.tsx b/ui/src/components/domain/enrichment/EnrichmentResults.tsx
@@ -544,20 +544,20 @@ export default function EnrichmentResults() {
     };
 
     const errorMsg = () => {
-        let msgs: string[] = [];
+        const msgs: string[] = [];
         if (enrichmentDetails?.ignored && enrichmentDetails.ignored.length > 0) {
             msgs.push(
                 `Ignored ${enrichmentDetails.ignored.length} artifact${enrichmentDetails.ignored.length > 1 ? 's' : ''}`,
             );
         }
-        let warn_count =
+        const warn_count =
             enrichmentDetails?.enrichers?.filter(
                 (enricher) => enricher.status === 'warning',
             ).length || 0;
         if (warn_count > 0) {
             msgs.push(`Warnings in ${warn_count} enricher${warn_count > 1 ? 's' : ''}`);
         }
-        let error_count =
+        const error_count =
             enrichmentDetails?.enrichers?.filter(
                 (enricher) => enricher.status === 'error',
             ).length || 0;
diff --git a/ui/src/components/domain/enrichment/dialogs/EnrichmentRequestDialog.tsx b/ui/src/components/domain/enrichment/dialogs/EnrichmentRequestDialog.tsx
@@ -171,7 +171,7 @@ export default function EnrichmentRequestDialog({
     };
 
     useEffect(() => {
-        let entities: { [key: number]: OptimizedEntryResponse } = {};
+        const entities: { [key: number]: OptimizedEntryResponse } = {};
         for (const note of notesList || []) {
             for (const entity of note.entities) {
                 if (selectedNoteIds.has(note.id)) {
@@ -214,7 +214,7 @@ export default function EnrichmentRequestDialog({
                 // Resolve entities list if provided
                 let resolvedEntities: number[] | undefined;
                 if (entitiesList && allEntitiesData) {
-                    let entities = await Promise.resolve(entitiesList);
+                    const entities = await Promise.resolve(entitiesList);
                     resolvedEntities = entities.map(
                         (entity) =>
                             allEntitiesData.find(
diff --git a/ui/src/components/domain/notes/NoteViewer.tsx b/ui/src/components/domain/notes/NoteViewer.tsx
@@ -281,7 +281,7 @@ export default function NoteViewer() {
             const doc = view.state;
             let to = doc.selection.main.to;
             let from = doc.selection.main.from;
-            let content = doc.doc.toString();
+            const content = doc.doc.toString();
 
             if (to === from) {
                 from = 0;
@@ -321,7 +321,7 @@ export default function NoteViewer() {
 
         let to = view.state.selection.main.to;
         let from = view.state.selection.main.from;
-        let content = view.state.doc.toString();
+        const content = view.state.doc.toString();
 
         if (to === from) {
             from = 0;
diff --git a/ui/src/components/domain/notes/NotesListPage.tsx b/ui/src/components/domain/notes/NotesListPage.tsx
@@ -143,7 +143,7 @@ export default function NotesListPage() {
         column: string,
         value: string | DateRangeFilter,
     ) => {
-        let updatedFilters = { ...searchFilters };
+        const updatedFilters = { ...searchFilters };
 
         if (column === 'createdAt' && typeof value === 'object') {
             updatedFilters.created_date_from = value.from || '';
diff --git a/ui/src/utils/dashboard.tsx b/ui/src/utils/dashboard.tsx
@@ -32,7 +32,7 @@ export class SubtypeHierarchy {
         this.tree = {};
         this.pathsMap = {};
 
-        for (let path of paths) {
+        for (const path of paths) {
             // Store the original full path
             this.pathsMap[path] = true;
 
diff --git a/ui/src/utils/editor/enhancements.ts b/ui/src/utils/editor/enhancements.ts
@@ -210,7 +210,7 @@ export class CradleEditor {
                                 tries[entryClass.subtype] = new DynamicTrie(
                                     async (x) => {
                                         try {
-                                            let result =
+                                            const result =
                                                 await this._lspApi.lspTrieRetrieve({
                                                     type: entryClass.subtype,
                                                     prefix: x,
@@ -564,21 +564,21 @@ export class CradleEditor {
 
         const pos = context.pos;
         const tree = syntaxTree(context.state);
-        let node = tree.resolve(pos, -1);
+        const node = tree.resolve(pos, -1);
 
         let options: Array<{ label: string; type: string; info?: string }> = [];
-        let from = node.from;
-        let to = node.to;
+        const from = node.from;
+        const to = node.to;
 
-        let path = this.getParent(node, 'BlockMapping');
+        const path = this.getParent(node, 'BlockMapping');
         if (path && path.length >= 2 && path.length <= 7) {
-            let section = path[1];
+            const section = path[1];
             if (section && section.firstChild) {
-                let sectxt = context.state.doc.sliceString(
+                const sectxt = context.state.doc.sliceString(
                     section.firstChild.from,
                     section.firstChild.to,
                 );
-                let parent = node.parent;
+                const parent = node.parent;
                 if (sectxt == 'entries' && parent != null) {
                     if (
                         parent.name == 'Key' ||
@@ -657,7 +657,7 @@ export class CradleEditor {
 
         const pos = context.pos;
         const tree = syntaxTree(context.state);
-        let node = tree.resolve(pos, -1);
+        const node = tree.resolve(pos, -1);
 
         let options: Array<{ label: string; type: string }> = [];
         let from = node.from;
@@ -935,12 +935,12 @@ export class CradleEditor {
             enter: (syntaxNode) => {
                 const node = syntaxNode.node;
                 if (node.name === 'CradleLink') {
-                    let typeNode = node.getChildren('CradleLinkType');
-                    let valueNode = node.getChildren('CradleLinkValue');
+                    const typeNode = node.getChildren('CradleLinkType');
+                    const valueNode = node.getChildren('CradleLinkValue');
                     if (!typeNode || !valueNode) return true;
 
-                    let type = text.slice(typeNode[0].from, typeNode[0].to);
-                    let value = text.slice(valueNode[0].from, valueNode[0].to);
+                    const type = text.slice(typeNode[0].from, typeNode[0].to);
+                    const value = text.slice(valueNode[0].from, valueNode[0].to);
 
                     entries.push({
                         type,
@@ -953,8 +953,8 @@ export class CradleEditor {
             },
         });
 
-        let artifacts: Array<{ type: string; value: string }> = [];
-        let entities: Array<{ type: string; value: string }> = [];
+        const artifacts: Array<{ type: string; value: string }> = [];
+        const entities: Array<{ type: string; value: string }> = [];
         for (const entry of entries) {
             if (this.entryClasses?.[entry.type].type === 'entity') {
                 entities.push(entry);
@@ -994,8 +994,8 @@ export class CradleEditor {
                         node.name == 'Frontmatter' ||
                         node.name == 'FrontMatterContent'
                     ) {
-                        let frontmatter = text.slice(node.from, node.to);
-                        let yml = frontmatter
+                        const frontmatter = text.slice(node.from, node.to);
+                        const yml = frontmatter
                             .substring(3, frontmatter.length - 4)
                             .trim();
                         try {
@@ -1063,9 +1063,9 @@ export class CradleEditor {
                                 }
                             }
                         } catch (e: any) {
-                            var loc = e.mark;
-                            var from = loc ? loc.position : 0;
-                            var to = from;
+                            const loc = e.mark;
+                            const from = loc ? loc.position : 0;
+                            const to = from;
                             diagnostics.push({
                                 from: from,
                                 to: to,
diff --git a/ui/src/utils/parser/extensions.ts b/ui/src/utils/parser/extensions.ts
@@ -65,7 +65,7 @@ const LINK_REGEX =
     /^(?:~)?\[\[([^:|]+?):((?:\\[[\]|]|[^[\]|])+?)(?:\|((?:\\[[\]|]|[^[\]|])+?))?\]\](?:\((?:(\d{2}:\d{2}\s+)?(\d{2}-\d{2}-\d{4}))\))?/;
 
 export function cradleLinkRule(state: any, silent: boolean): boolean {
-    let str = state.src.slice(state.pos);
+    const str = state.src.slice(state.pos);
     const match = LINK_REGEX.exec(str);
     if (!match) return false;
     if (silent) return false;
@@ -131,7 +131,7 @@ export function renderFootnoteRef(token: Token): string {
 }
 
 let DownloadLinkPromiseCache: Record<string, Promise<FileDownload>> = {};
-let MinioCache: Record<string, FileDownload> = {};
+const MinioCache: Record<string, FileDownload> = {};
 
 export function fetchMinioDownloadLink(
     fileTransferApi: FileTransferApi,
@@ -173,7 +173,7 @@ export async function resolveMinioLinks(
         const fileId = params.get('fileId');
         if (!fileId) return;
 
-        let cached = MinioCache[fileId];
+        const cached = MinioCache[fileId];
         let presigned: string | undefined = cached?.presignedUrl;
         let expiry: number | undefined = cached?.expiresIn;
         if (!presigned || Date.now() > (expiry || 0)) {
@@ -312,7 +312,7 @@ export async function parseWithExtensions(
 
     let metadata = {};
     try {
-        let note = matter(mdContent, {
+        const note = matter(mdContent, {
             engines: {
                 yaml: (data) => {
                     try {
