Skip to content

Commit bcf4e25

Browse files
committed
fix: disable loki as default ds
1 parent 4a89857 commit bcf4e25

File tree

3 files changed

+8
-26
lines changed

3 files changed

+8
-26
lines changed

kubernetes-services/additions/prometheus/loki-datasource.yaml

Lines changed: 0 additions & 18 deletions
This file was deleted.

kubernetes-services/templates/prometheus.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,6 @@ spec:
6262
grafana:
6363
deploymentStrategy:
6464
type: Recreate
65-
grafana.ini:
66-
server:
67-
serve_from_sub_path: true
6865
persistence:
6966
enabled: true
7067
type: pvc
@@ -91,6 +88,8 @@ spec:
9188
targetRevision: 2.10.3
9289
helm:
9390
values: |
91+
loki:
92+
isDefault: false
9493
grafana:
9594
enabled: false
9695
prometheus:

test/prometheus_test.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@ package test
22

33
import (
44
"context"
5-
"github.com/stretchr/testify/require"
6-
"sigs.k8s.io/e2e-framework/pkg/envconf"
7-
"sigs.k8s.io/e2e-framework/pkg/features"
85
"strings"
96
"test/test/pkg/test"
107
"testing"
8+
9+
"github.com/stretchr/testify/require"
10+
"sigs.k8s.io/e2e-framework/pkg/envconf"
11+
"sigs.k8s.io/e2e-framework/pkg/features"
1112
)
1213

1314
func TestPrometheus(t *testing.T) {
@@ -95,7 +96,7 @@ func TestPrometheus(t *testing.T) {
9596
t.Fatalf("Failed to get kubernetes client #%v", err)
9697
}
9798

98-
install := features.
99+
_ = features.
99100
New("Deploying Prometheus Helm Chart").
100101
Setup(func(ctx context.Context, t *testing.T, cfg *envconf.Config) context.Context {
101102
err = test.DeployHelmCharts(cfg.KubeconfigFile(), promCurrent)
@@ -147,5 +148,5 @@ func TestPrometheus(t *testing.T) {
147148
}).
148149
Feature()
149150

150-
ciTestEnv.Test(t, install, upgrade)
151+
ciTestEnv.Test(t, upgrade)
151152
}

0 commit comments

Comments
 (0)