[p5.js 2.0+ Bug Report]: Vector.equals() is quirky when dimensions are not equal

[sidwellr]

Most appropriate sub-area of p5.js?

• Accessibility
• Color
• Core/Environment/Rendering
• Data
• DOM
• Events
• Image
• IO
• Math
• Typography
• Utilities
• WebGL
• WebGPU
• p5.strands
• Build process
• Unit testing
• Internationalization
• Friendly errors
• Other (specify if possible)

p5.js version

2.3.0

Web browser and version

Brave 1.90.122

Operating system

Linux Mint 22.1

Steps to reproduce this

Snippet:

function setup() {
  let v1 = createVector(1, 2, 3);
  let v2 = createVector(1, 2, 3, 4);
  
  // Equals is symmetric so these should print the same values, but they don't
  print(v1.equals(v2));
  print(v2.equals(v1));
}

Discussion

To be consistent with other Vector methods, equals() should log a warning if the two vectors have different lengths, then compare the components up to the smallest length.

[vamshi567bh]

@ksen0 @sidwellr i would like to work on this please assign

[ksen0]

HI @vamshi567bh thanks for the interest! Seems like you're new to the repo, welcome! I recommend looking for issues labeled "Good First Issue." This one in particular is a bit particular, in this case I would assign someone who's contributed in the past (especially in math area).

To document the discussion from Discord:

• do not apply smallest-vector priority logic; this should be covered in unit tests
• as issue suggests, test should be symmetrical; this should be covered in unit tests
• in the example, both should be false.

Solution should update equals to have correct behavior but also add multiple unittests to prevent regression

[vamshi567bh]

I have a fix ready locally and can fix this issue tests are passing locally. i have disscused in discord if it looks good please assign thanks!