fix(planner): resolve four planner/verifier bugs blocking reconciliation

Squashed from fix/planner-issues branch (22 commits) for clean rebase onto main.

- TML-2077: ALTER TYPE postcheck uses format_type() instead of column existence
- TML-2087: indexOrConstraint populated on extra-object issues
- TML-2088: FK detection in strict mode when contract has no FKs
- TML-2091: extra_default detection and DROP DEFAULT operation
- default_missing operation builder (additive SET DEFAULT)
- default_mismatch operation builder (widening, known-failing: TML-2089)
- buildExpectedFormatType with FORMAT_TYPE_DISPLAY, mixed-case UDT quoting (P1-2, P1-4)
- constraintExistsCheck scoped to table with to_regclass() (P2-1)
- autoincrement guard in buildDefaultOperation (TML-2107)
- it.fails annotations for TML-2089, TML-2135
- Integration + unit tests

Author: saevarb

packages/1-framework/1-core/migration/control-plane/src/types.ts

@@ -408,7 +408,8 @@ export interface SchemaIssue {
     | 'index_mismatch'
     | 'dependency_missing'
     | 'default_missing'
-    | 'default_mismatch';
+    | 'default_mismatch'
+    | 'extra_default';
   readonly table?: string;
   readonly column?: string;
   readonly indexOrConstraint?: string;

packages/1-framework/1-core/shared/config/src/types.ts

@@ -208,7 +208,8 @@ export interface SchemaIssue {
     | 'index_mismatch'
     | 'dependency_missing'
     | 'default_missing'
-    | 'default_mismatch';
+    | 'default_mismatch'
+    | 'extra_default';
   readonly table?: string;
   readonly column?: string;
   readonly indexOrConstraint?: string;

packages/2-sql/3-tooling/family/src/core/schema-verify/verify-helpers.ts

@@ -236,6 +236,7 @@ export function verifyForeignKeys(
         issues.push({
           kind: 'extra_foreign_key',
           table: tableName,
+          indexOrConstraint: schemaFK.name ?? `fk(${schemaFK.columns.join(',')})`,
           message: `Extra foreign key found in database (not in contract): ${schemaFK.columns.join(', ')} -> ${schemaFK.referencedTable}(${schemaFK.referencedColumns.join(', ')})`,
         });
         nodes.push({
@@ -338,6 +339,7 @@ export function verifyUniqueConstraints(
         issues.push({
           kind: 'extra_unique_constraint',
           table: tableName,
+          indexOrConstraint: schemaUnique.name ?? `unique(${schemaUnique.columns.join(',')})`,
           message: `Extra unique constraint found in database (not in contract): ${schemaUnique.columns.join(', ')}`,
         });
         nodes.push({
@@ -445,6 +447,7 @@ export function verifyIndexes(
         issues.push({
           kind: 'extra_index',
           table: tableName,
+          indexOrConstraint: schemaIndex.name ?? `idx(${schemaIndex.columns.join(',')})`,
           message: `Extra index found in database (not in contract): ${schemaIndex.columns.join(', ')}`,
         });
         nodes.push({

packages/2-sql/3-tooling/family/src/core/schema-verify/verify-sql-schema.ts

@@ -348,6 +348,7 @@ function verifyTableChildren(options: {
     tableName,
     tablePath,
     issues,
+    strict,
     typeMetadataRegistry,
     codecHooks,
     ...ifDefined('normalizeDefault', normalizeDefault),
@@ -418,9 +419,11 @@ function verifyTableChildren(options: {
     });
   }
 
-  // Verify FK constraints only for FKs with constraint: true
+  // Verify FK constraints only for FKs with constraint: true.
+  // Always call when strict mode is on so extra-FK detection runs even if
+  // the contract has no FKs for this table.
   const constraintFks = contractTable.foreignKeys.filter((fk) => fk.constraint === true);
-  if (constraintFks.length > 0) {
+  if (constraintFks.length > 0 || strict) {
     const fkStatuses = verifyForeignKeys(
       constraintFks,
       schemaTable.foreignKeys,
@@ -475,6 +478,7 @@ function collectContractColumnNodes(options: {
   tableName: string;
   tablePath: string;
   issues: SchemaIssue[];
+  strict: boolean;
   typeMetadataRegistry: ReadonlyMap<string, { nativeType?: string }>;
   codecHooks: Map<string, CodecControlHooks>;
   normalizeDefault?: DefaultNormalizer;
@@ -486,6 +490,7 @@ function collectContractColumnNodes(options: {
     tableName,
     tablePath,
     issues,
+    strict,
     typeMetadataRegistry,
     codecHooks,
     normalizeDefault,
@@ -526,6 +531,7 @@ function collectContractColumnNodes(options: {
         schemaColumn,
         columnPath,
         issues,
+        strict,
         typeMetadataRegistry,
         codecHooks,
         ...ifDefined('normalizeDefault', normalizeDefault),
@@ -576,6 +582,7 @@ function verifyColumn(options: {
   schemaColumn: SqlSchemaIR['tables'][string]['columns'][string];
   columnPath: string;
   issues: SchemaIssue[];
+  strict: boolean;
   typeMetadataRegistry: ReadonlyMap<string, { nativeType?: string }>;
   codecHooks: Map<string, CodecControlHooks>;
   normalizeDefault?: DefaultNormalizer;
@@ -588,6 +595,7 @@ function verifyColumn(options: {
     schemaColumn,
     columnPath,
     issues,
+    strict,
     codecHooks,
     normalizeDefault,
     normalizeNativeType,
@@ -728,6 +736,26 @@ function verifyColumn(options: {
       });
       columnStatus = 'fail';
     }
+  } else if (strict && schemaColumn.default) {
+    issues.push({
+      kind: 'extra_default',
+      table: tableName,
+      column: columnName,
+      actual: schemaColumn.default,
+      message: `Column "${tableName}"."${columnName}" has default ${schemaColumn.default} in database but contract specifies no default`,
+    });
+    columnChildren.push({
+      status: 'fail',
+      kind: 'default',
+      name: 'default',
+      contractPath: `${columnPath}.default`,
+      code: 'extra_default',
+      message: `Extra default: ${schemaColumn.default}`,
+      expected: undefined,
+      actual: schemaColumn.default,
+      children: [],
+    });
+    columnStatus = 'fail';
   }
 
   // Single-pass aggregation for better performance

packages/2-sql/3-tooling/family/test/schema-verify.strict.test.ts

@@ -115,4 +115,56 @@ describe('verifySqlSchema - result structure', () => {
       totalNodes: expect.any(Number),
     });
   });
+
+  it('detects extra foreign keys when contract has no FKs for the table', () => {
+    const contract = createTestContract({
+      parent: createContractTable({
+        id: { nativeType: 'int4', nullable: false },
+      }),
+      child: createContractTable({
+        id: { nativeType: 'int4', nullable: false },
+        parent_id: { nativeType: 'int4', nullable: false },
+      }),
+    });
+
+    const schema = createTestSchemaIR({
+      parent: createSchemaTable('parent', {
+        id: { nativeType: 'int4', nullable: false },
+      }),
+      child: createSchemaTable(
+        'child',
+        {
+          id: { nativeType: 'int4', nullable: false },
+          parent_id: { nativeType: 'int4', nullable: false },
+        },
+        {
+          foreignKeys: [
+            {
+              columns: ['parent_id'],
+              referencedTable: 'parent',
+              referencedColumns: ['id'],
+              name: 'child_parent_id_fkey',
+            },
+          ],
+        },
+      ),
+    });
+
+    const result = verifySqlSchema({
+      contract,
+      schema,
+      strict: true,
+      typeMetadataRegistry: emptyTypeMetadataRegistry,
+      frameworkComponents: [],
+    });
+
+    expect(result.ok).toBe(false);
+    expect(result.schema.issues).toContainEqual(
+      expect.objectContaining({
+        kind: 'extra_foreign_key',
+        table: 'child',
+        indexOrConstraint: 'child_parent_id_fkey',
+      }),
+    );
+  });
 });