-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
Type: EnhancementIssue contains an enhancement related to a specific component. Additional functionality has been addIssue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
Description
Describe the bug
I'm trying to use prime react together with module federation. This gives many warnings like the following if the prime react version isn't manually specified version in the module federation configuration:
[...]
WARNING in shared module C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\overlayservice\overlayservice.esm.js -> C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\overlayservice\overlayservice.esm.js
No version specified and unable to automatically determine one. No version in description file (usually package.json). Add version to description file C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\overlayservice\package.json, or manually specify version in shared config.
WARNING in shared module C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\portal\portal.esm.js -> C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\portal\portal.esm.js
No version specified and unable to automatically determine one. No version in description file (usually package.json). Add version to description file C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\portal\package.json, or manually specify version in shared config.
WARNING in shared module C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\progressbar\progressbar.esm.js -> C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\progressbar\progressbar.esm.js
No version specified and unable to automatically determine one. No version in description file (usually package.json). Add version to description file C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\progressbar\package.json, or manually specify version in shared config.
WARNING in shared module C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\ripple\ripple.esm.js -> C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\ripple\ripple.esm.js
No version specified and unable to automatically determine one. No version in description file (usually package.json). Add version to description file C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\ripple\package.json, or manually specify version in shared config.
WARNING in shared module C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\utils\utils.esm.js -> C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\utils\utils.esm.js
No version specified and unable to automatically determine one. No version in description file (usually package.json). Add version to description file C:\Users\mju\git\docbridge-central-2-plugin-resource-director\node_modules\primereact\utils\package.json, or manually specify version in shared config.
Having the version in the generated package.jsons means that module federation can automatically determine the version.
Reproducer
No response
System Information
npmPackages:
primeReact: 10.9.6Steps to reproduce the behavior
No response
Expected behavior
Expected package.json content, example for utils, but needed for all packages:
{
"main": "./utils.cjs.js",
"module": "./utils.esm.js",
"unpkg": "./utils.min.js",
"types": "./utils.d.ts",
"sideEffects": false,
"version": "10.9.6"
}
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type: EnhancementIssue contains an enhancement related to a specific component. Additional functionality has been addIssue contains an enhancement related to a specific component. Additional functionality has been add