fix: handle yieldfrom parenthesization in needsParens (#2466)

Author: jorgsowa

src/needs-parens.mjs

@@ -142,7 +142,8 @@ function needsParens(path, options) {
           return false;
       }
     }
-    case "yield": {
+    case "yield":
+    case "yieldfrom": {
       switch (parent.kind) {
         case "propertylookup":
         case "nullsafepropertylookup":
@@ -154,8 +155,11 @@ function needsParens(path, options) {
         case "retif":
           return key === "test";
 
+        case "assign":
+          return node.kind === "yield" && !!(node.key || node.value);
+
         default:
-          return !!(node.key || node.value);
+          return node.kind === "yieldfrom" || !!(node.key || node.value);
       }
     }
     case "assign": {

tests/yield/__snapshots__/jsfmt.spec.mjs.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`yield.php 1`] = `
 ====================================options=====================================
@@ -64,6 +64,13 @@ function foo() {
   $test = 123;
   yield "bar {$test}" => 123;
 }
+function bar() {
+  $x = yield from $gen;
+  $cond ? yield from $gen : $fallback;
+  foo(yield from $gen);
+  (yield from $gen)->method();
+  $a && yield from $gen;
+}
 
 =====================================output=====================================
 <?php
@@ -131,6 +138,14 @@ function foo()
     $test = 123;
     yield "bar {$test}" => 123;
 }
+function bar()
+{
+    $x = yield from $gen;
+    $cond ? yield from $gen : $fallback;
+    foo(yield from $gen);
+    (yield from $gen)->method();
+    $a && (yield from $gen);
+}
 
 ================================================================================
 `;

tests/yield/yield.php

@@ -56,3 +56,10 @@ function foo() {
   $test = 123;
   yield "bar {$test}" => 123;
 }
+function bar() {
+  $x = yield from $gen;
+  $cond ? yield from $gen : $fallback;
+  foo(yield from $gen);
+  (yield from $gen)->method();
+  $a && yield from $gen;
+}