Skip to content

Review our pr-verify workflow #357

@juanjosevazquezgil

Description

@juanjosevazquezgil

Motivation

Our pr-verify workflow seems to be working fine when called from a branch, but when we merge our changes into main it seems to fail with the following error:

# dagger/update-claims-features
Error: ./main.go:193:30: non-constant format string in call to fmt.Errorf
FAIL	dagger/update-claims-features [build failed]
FAIL

https://github.com/prefapp/daggerverse/actions/runs/19967265786/job/57262292937

While this is not very concerning, as the workflow correctly validates changes done in each branch individually and the update-claims-features module seems to be working fine (it was tested before opening this issue), this is still worth having a look at, as we don't know what kind of problems may arise in the future if we don't fix it.

The offending line of code is this: https://github.com/prefapp/daggerverse/blob/main/update-claims-features/main.go#L193

if errorMsg != "" {
	returnedError = fmt.Errorf(errorMsg)
}

Looking at it, we can probably solve this by just changing returnedError to returnedError = errorMsg, as errorMsg is the result of a previous call to fmt.Errorf().

Acceptance criteria

  • The cause of the error has been determined
  • The error has been fixed

Metadata

Metadata

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions