Add support for removing all reviewers from PGConf.dev tagged patches

Author: JelteF

pgcommitfest/commitfest/fixtures/commitfest_data.json

@@ -353,6 +353,15 @@
         "description": "Improves security"
     }
 },
+{
+    "model": "commitfest.tag",
+    "pk": 30,
+    "fields": {
+        "name": "PGConf.dev",
+        "color": "#336791",
+        "description": "part of the PGConf.dev in-person commitfest — see https://wiki.postgresql.org/wiki/PGConf.dev_2026_In-Person_Commitfest"
+    }
+},
 {
     "model": "commitfest.patch",
     "pk": 1,

pgcommitfest/commitfest/models.py

@@ -536,6 +536,10 @@ def current_patch_on_commitfest(self):
             PatchOnCommitFest, Q(patch=self) & ~Q(status=PatchOnCommitFest.STATUS_MOVED)
         )
 
+    @property
+    def can_remove_all_reviewers(self):
+        return self.tags.filter(name="PGConf.dev").exists()
+
     # Some accessors
     @property
     def authors_string(self):

pgcommitfest/commitfest/templates/patch.html

@@ -119,7 +119,11 @@
    </tr>
    <tr>
     <th>Reviewers</th>
-    <td>{{patch.reviewers_string}}<a href="reviewer/{{is_reviewer|yesno:"remove,become"}}/" class="btn btn-secondary float-end">{{is_reviewer|yesno:"Remove from reviewers,Become reviewer"}}</a></td>
+    <td>
+     {{patch.reviewers_string}}
+     {%if is_reviewer%}<a href="reviewer/remove/" class="btn btn-secondary float-end">Remove from reviewers</a>{%else%}<a href="reviewer/become/" class="btn btn-secondary float-end">Become reviewer</a>{%endif%}
+     {%if patch.can_remove_all_reviewers and patch.reviewers.all%}<a href="reviewer/remove_all/" class="btn btn-secondary float-end me-1">Remove all reviewers</a>{%endif%}
+    </td>
    </tr>
    <tr>
     <th>Committer</th>

pgcommitfest/commitfest/tests/test_remove_reviewer.py

@@ -0,0 +1,59 @@
+from datetime import datetime
+
+import pytest
+
+from pgcommitfest.commitfest.models import (
+    Patch,
+    PatchHistory,
+    PatchOnCommitFest,
+    PendingNotification,
+    Tag,
+)
+from pgcommitfest.userprofile.models import UserProfile
+
+pytestmark = pytest.mark.django_db
+
+
+def test_remove_all_reviewers(client, open_cf, alice, bob, charlie):
+    UserProfile.objects.create(user=bob, notify_all_reviewer=True)
+
+    pgconfdev_tag = Tag.objects.create(
+        name="PGConf.dev", color="#000000", description="PGConf.dev"
+    )
+    patch = Patch.objects.create(name="Test patch")
+    patch.authors.add(alice)
+    patch.reviewers.add(bob, charlie)
+    patch.tags.add(pgconfdev_tag)
+    PatchOnCommitFest.objects.create(
+        patch=patch,
+        commitfest=open_cf,
+        enterdate=datetime.now(),
+        status=PatchOnCommitFest.STATUS_REVIEW,
+    )
+
+    client.force_login(alice)
+    response = client.get(f"/patch/{patch.id}/reviewer/remove_all/")
+    assert response.status_code == 302
+    assert list(patch.reviewers.all()) == []
+    assert (
+        "Removed all reviewers"
+        in PatchHistory.objects.filter(patch=patch).latest("date").what
+    )
+    assert PendingNotification.objects.filter(user=bob).exists()
+
+
+def test_remove_all_reviewers_forbidden_without_tag(client, open_cf, alice, bob):
+    patch = Patch.objects.create(name="Test patch")
+    patch.authors.add(alice)
+    patch.reviewers.add(bob)
+    PatchOnCommitFest.objects.create(
+        patch=patch,
+        commitfest=open_cf,
+        enterdate=datetime.now(),
+        status=PatchOnCommitFest.STATUS_REVIEW,
+    )
+
+    client.force_login(alice)
+    response = client.get(f"/patch/{patch.id}/reviewer/remove_all/")
+    assert response.status_code == 403
+    assert bob in patch.reviewers.all()

pgcommitfest/commitfest/views.py

@@ -1353,6 +1353,31 @@ def reviewer(request, patchid, status):
     return HttpResponseRedirect("../../")
 
 
+@login_required
+@transaction.atomic
+def remove_all_reviewers(request, patchid):
+    patch = get_object_or_404(Patch, pk=patchid)
+
+    if not patch.can_remove_all_reviewers:
+        return HttpResponseForbidden(
+            "Removing reviewers is only allowed for PGConf.dev patches."
+        )
+
+    prevreviewers = list(patch.reviewers.all())
+    if not prevreviewers:
+        return HttpResponseRedirect(f"/patch/{patchid}/")
+
+    patch.reviewers.clear()
+    patch.set_modified()
+    patch.save()
+    PatchHistory(
+        patch=patch,
+        by=request.user,
+        what="Removed all reviewers",
+    ).save_and_notify(prevreviewers=prevreviewers)
+    return HttpResponseRedirect(f"/patch/{patchid}/")
+
+
 @login_required
 @transaction.atomic
 def committer(request, patchid, status):

pgcommitfest/urls.py

@@ -35,6 +35,7 @@
     re_path(r"^patch/(\d+)/close/(reject|withdrawn|feedback|committed)/$", views.close),
     re_path(r"^patch/(\d+)/move/$", views.move),
     re_path(r"^patch/(\d+)/reviewer/(become|remove)/$", views.reviewer),
+    re_path(r"^patch/(\d+)/reviewer/remove_all/$", views.remove_all_reviewers),
     re_path(r"^patch/(\d+)/committer/(become|remove)/$", views.committer),
     re_path(r"^patch/(\d+)/(un)?subscribe/$", views.subscribe),
     re_path(r"^patch/(\d+)/(comment|review)/", views.comment),