Problem: users cannot set which minor version of postgresql package to use when building dev pkg

In its official deb repository, postgresql packages may have the following
names:

    postgresql-17
    postgresql-16
    postgresql-15

etc. The problem here is that the latest minor version will be installed, wherease
users may want a different version.

Solution: packages have versions. Inside pbuilder_install_script.sh.erb we pick
up which version our user wants and match it agains what's available. If it
exists, we install that particular version:

    ...
    apt -y install postgresql-$PG_MAJOR_VERSION=$pkg_version
    ...

And then build the local podman image named after the chosen postgresql version.
If user selected postgresql version 17.14 on amd64, the image will be called:

    pgpm-debian-pg17.4-amd64

BONUS FIX: LD_CONFIG error messages are no longer present!

Author: qount25

lib/pgpm/deb/builder.rb

@@ -142,9 +142,20 @@ def build_local_image
           puts "  Updating chroot image..."
           system("podman exec -w /root pgpm-deb-tmp /bin/bash -c 'fakeroot pbuilder execute --save-after-exec ./pbuilder_install_script.sh'")
 
-          system("podman stop pgpm-deb-tmp")
+          # Exiting -- most likely error occurred because we cannot find the same
+          # postgresql version in the Debian repository. The bash script
+          # will do error reporting for us, so we just exit.
+          if $CHILD_STATUS.to_i.positive?
+            stop_and_remove_deb_tmp_image
+            exit 1
+          end
           system("podman commit pgpm-deb-tmp #{image_name}")
-          system("podman container rm pgpm-deb-tmp")
+          stop_and_remove_deb_tmp_image
+      end
+
+      def stop_and_remove_deb_tmp_image
+        system("podman stop pgpm-deb-tmp")
+        system("podman container rm pgpm-deb-tmp")
       end
 
       def generate_deb_src_files(pkg_type = :versioned)
@@ -192,7 +203,7 @@ def run_build(pkg_type = :versioned)
 
         cmds = []
         cmds << "dpkg-buildpackage --build=source -d" # -d flag helps with dependencies error
-        cmds << "fakeroot pbuilder build ../#{dsc_fn}"
+        cmds << "pbuilder build ../#{dsc_fn}"
         cmds << "mv /var/cache/pbuilder/result/#{deb_fn} /root/pgpm/out/"
 
         puts "  Building package with pbuilder..."

lib/pgpm/deb/spec.rb

@@ -60,6 +60,7 @@ def cmds_if_not_empty(cmds, else_echo)
         cmds.map! { |c| c.gsub("$", "$$") }
         cmds.join("\t")
       end
+
     end
   end
 end

lib/pgpm/deb/templates/pbuilder_install_script.sh.erb

@@ -1,15 +1,26 @@
 #!/usr/bin/env bash
 
 # Run this script with:
-#     fakeroot pbuilder execute --save-after-exec ./pbuilder_install_script.sh
+#     fakeroot pbuilder execute --save-after-exec path/to/pbuilder_install_script.sh
 
+
+# This helps us avoid almost all instances of a very annoying:
+#
+#     ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded...
+#
+# which isn't critical, but is polluting the output and makes debugging or
+# simply reading the output more difficult.
+export LD_PRELOAD="$(find / -name libfakeroot-sysv.so 2>/dev/null)"
+
+# These packages are universally required by pbuilder, so we pre-install them
+# inside our chroot.
 apt update
 DEBIAN_FRONTEND=noninteractive apt -y install                                   \
   build-essential curl lsb-release ca-certificates automake autopoint           \
   autotools-dev bsdextrautils debhelper dh-autoreconf dh-strip-nondeterminism   \
   dwz file gettext gettext-base groff-base intltool-debian libarchive-zip-perl  \
   libdebhelper-perl libelf1t64 libfile-stripnondeterminism-perl libmagic-mgc    \
-  libmagic1t64 libpipeline1 libtool libuchardet0 man-db po-debconf
+  libmagic1t64 libpipeline1 libtool libuchardet0 man-db po-debconf fakeroot
 
 ### PostgreSQL installation
 #
@@ -19,20 +30,32 @@ curl -o /usr/share/postgresql-common/pgdg/apt.postgresql.org.asc --fail https://
 # Create the repository configuration file:
 sh -c 'echo "deb [signed-by=/usr/share/postgresql-common/pgdg/apt.postgresql.org.asc] https://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list'
 
+# Add archive repos containing all postgres versions deleted from
+# apt.postgresql.org. For example, when version 17.4 came out, version 17.3
+# was moved to the archive-apt source. We want all of them, because we don't know
+# ahead of time which version is going to be required by the user.
+apt_sources_fn="/etc/apt/sources.list.d/pgdg.list"
+cat $apt_sources_fn | grep 's|https://apt|https://apt-archive' >> $apt_sources_fn
+
 # Update the package lists:
 apt update
 
-# Install PostgreSQL. We first try a package with the full version name, but if
-# (such as postgresql-17.4), but if that's not the name that exists in the apt
-# repository, we use postgresql-17 instead.
-PG_VERSION=<%= @package.postgres_version(:major) %>
-
-# Checking if the output is empty, because `apt search` returns status 0
-# even if doesn't find anything.
-if [[ $(apt-cache search --names-only postgresql-<%= @package.postgres_version %> | head -c1 | wc -c) -ne 0 ]]; then
-  PG_VERSION=<%= @package.postgres_version %>
+PG_VERSION=<%= @package.postgres_version %>
+PG_MAJOR_VERSION=<%= @package.postgres_version(:major) %>
+
+# Let's check if the version we're trying to install actually exists.
+pkg="$(apt-cache madison postgresql-$PG_MAJOR_VERSION | grep " | $PG_VERSION" | head -n1)"
+if [[ "$pkg" == "" ]]; then
+  # If it doesn't we exit with status 1 and an explanation of an error. This will
+  # trigger the caller (spec.rb) to also exit with status one and, thus, will
+  # not build a local image -- because user-requested version of postgresql
+  # cannot be found in the repository.
+  >&2 echo "ERROR:"
+  >&2 echo "  Couldn't find postgresql-$PG_MAJOR_VERSION package with version $PG_VERSION."
+  exit 1
+else
+  pkg_version="$(echo "$pkg" | cut -d "|" -f 2 | xargs)"
+  apt -y install postgresql-$PG_MAJOR_VERSION=$pkg_version            \
+                 postgresql-server-dev-$PG_MAJOR_VERSION=$pkg_version \
+                 postgresql-common
 fi
-
-apt -y install postgresql-$PG_VERSION            \
-               postgresql-server-dev-$PG_VERSION \
-               postgresql-common

lib/pgpm/package/dependencies.rb

@@ -11,8 +11,8 @@ def build_dependencies
         case Pgpm::OS.in_scope.class.name
         when "debian", "ubuntu"
           deps = [
-            "postgresql-#{postgres_version(:major)}",
-            "postgresql-server-dev-#{postgres_version(:major)}",
+            "postgresql-#{postgres_version(:major)} (>= #{postgres_version})",
+            "postgresql-server-dev-#{postgres_version(:major)} (>= #{postgres_version})",
             "postgresql-common"
           ]
           if native?
@@ -26,7 +26,7 @@ def build_dependencies
       def dependencies
         case Pgpm::OS.in_scope.class.name
         when "debian", "ubuntu"
-          ["postgresql-#{postgres_version(:major)}"]
+          ["postgresql-#{postgres_version(:major)} (>= #{postgres_version})"]
         when "rocky+epel-9", "redhat", "fedora"
           []
         end