Make the module "Context Aware"

[alba-ado]

Hello,

The nfc-pcsc library causes trouble with the newer versions of the electron ( After v16) because this module is not context aware. However, we solved this issue and confirmed to be working with nfc-pcsc in santigimeno's node-pcsclite repo as follows;

santigimeno@64952fb

By just adding a few lines, we can make the module context aware. I tried this by myself on the nfc-pcsc library, and can confirm that it works without a problem (in the latest version of electron, which was 17 at the time of writing this). Can you make this change to the addon.cpp file and push this repo into the npm, so we can use the nfc-pcsc library with the new versions of the electron without changing the source files? (My understanding is that nfc-pcsc requires this repo, or am I wrong?)

Help is really appreciated. Thanks in advance.

[bastianandre-myenso]

Since there was no update by the maintainer so far I ended up doing the following:

1. Fork this repository
2. Apply the necessary changes to the fork
3. Install the forked package in your application

The package.json then looks like

"dependencies": {
    "@pokusew/pcsclite": "github:<your-account>/node-pcsclite"
}

To use with electron v28+ I suggest also updating the nan peer dependency to v2.19 as suggested here from this issue.

[alba-ado]

Yes, I ended up doing something similar. But I wanted to notify the maintainers of this library to update the code as well so everyone can use it.

[martinpaljak]

Maybe it makes sense to try to make a new "official community managed fork" and while at it, drop the "lite" from the name, node-pcsc ? Maybe @LudovicRousseau has ideas or proposals?

[LudovicRousseau]

I have nothing to add.
I do not use node.js, except for my article https://blog.apdu.fr/posts/2014/09/pcsc-sample-in-javascript-nodejs/

I agree with @martinpaljak that it is strange to use the name "pcsclite" if it is not specific to pcsc-lite but can work with any PC/SC (or WinSCard) library.

[alba-ado]

I have nothing to add. I do not use node.js, except for my article https://blog.apdu.fr/posts/2014/09/pcsc-sample-in-javascript-nodejs/

I agree with @martinpaljak that it is strange to use the name "pcsclite" if it is not specific to pcsc-lite but can work with any PC/SC (or WinSCard) library.

I think it comes from the Linux library name libpcsclite, that might be the naming reason

[alba-ado]

Maybe it makes sense to try to make a new "official community managed fork" and while at it, drop the "lite" from the name, node-pcsc ? Maybe @LudovicRousseau has ideas or proposals?

I agree that we can make a community fork, but who will be in charge of this and wants to take responsibility? 😄