Skip to content

Commit e2c29a9

Browse files
authored
Fix double parsing error for StorageUsedPercentage in SPODeletedSite (#5183)
* Fix double parsing error for StorageUsedPercentage in SPODeletedSite * Fix double parsing error for StorageUsedPercentage in SPODeletedSite
1 parent 2cf802a commit e2c29a9

File tree

1 file changed

+23
-1
lines changed

1 file changed

+23
-1
lines changed

src/Commands/Model/SPODeletedSite.cs

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,29 @@ internal SPODeletedSite(DeletedSiteProperties deletedSiteProperties, bool fetchA
197197
if (fieldValues["StorageUsed"] != null) StorageUsed = double.Parse(fieldValues["StorageUsed"].ToString());
198198
if (fieldValues["TemplateId"] != null) TemplateId = short.Parse(fieldValues["TemplateId"].ToString());
199199
if (fieldValues["LastItemModifiedDate"] != null) LastWebActivityOn = DateTime.Parse(fieldValues["LastItemModifiedDate"].ToString());
200-
if (fieldValues["StorageUsedPercentage"] != null) StorageUsedPercentage = double.Parse(fieldValues["StorageUsedPercentage"].ToString());
200+
try
201+
{
202+
if (fieldValues["StorageUsedPercentage"] != null)
203+
{
204+
var rawValue = fieldValues["StorageUsedPercentage"];
205+
if (rawValue is FieldCalculatedErrorValue)
206+
{
207+
Log.Debug("SPODeletedSite", $"StorageUsedPercentage returned FieldCalculatedErrorValue for '{Url}'. Raw type '{rawValue.GetType().FullName}'.");
208+
}
209+
else if (double.TryParse(rawValue.ToString(), out var storageUsedPercentage))
210+
{
211+
StorageUsedPercentage = storageUsedPercentage;
212+
}
213+
else
214+
{
215+
Log.Debug("SPODeletedSite", $"Unable to parse StorageUsedPercentage value '{rawValue}' (type '{rawValue?.GetType().FullName}') for '{Url}'.");
216+
}
217+
}
218+
}
219+
catch (Exception ex)
220+
{
221+
Log.Error("SPODeletedSite", $"Exception while parsing StorageUsedPercentage for '{Url}': {ex}");
222+
}
201223
if (fieldValues["SensitivityLabel"] != null) SensitivityLabelId = Guid.Parse(fieldValues["SensitivityLabel"].ToString());
202224
}
203225
else

0 commit comments

Comments
 (0)