Issue compiling

[stormyweathers]

Hey there,

I tried compiling this repo through your Turing Pattern repo. I ran
> cmake .
> make
And get:

[ 28%] Building CXX object CudaLight/CMakeFiles/HostRoutines.dir/HostRoutines/BufferInitializer.cpp.o
In file included from /home/user/repos/TuringPatterns/PdeFiniteDifferenceSolver/CudaLight/HostRoutines/BufferInitializer.cpp:3:0:
/home/user/repos/TuringPatterns/PdeFiniteDifferenceSolver/CudaLight/HostRoutines/Exceptions.h:13:22: error: ‘virtual const char* cl::NotImplementedException::what() const’ can be marked override [-Werror=suggest-override]
inline const char* what() const noexcept final { return "NotImplemented"; }
^~~~
/home/user/repos/TuringPatterns/PdeFiniteDifferenceSolver/CudaLight/HostRoutines/Exceptions.h:26:22: error: ‘virtual const char* cl::MklException::what() const’ can be marked override [-Werror=suggest-override]
inline const char* what() const noexcept final { return _callerFunction; }
^~~~
/home/user/repos/TuringPatterns/PdeFiniteDifferenceSolver/CudaLight/HostRoutines/Exceptions.h:42:22: error: ‘virtual const char* cl::OpenBlasException::what() const’ can be marked override [-Werror=suggest-override]
inline const char* what() const noexcept final { return _callerFunction; }
^~~~
cc1plus: all warnings being treated as errors
CudaLight/CMakeFiles/HostRoutines.dir/build.make:75: recipe for target 'CudaLight/CMakeFiles/HostRoutines.dir/HostRoutines/BufferInitializer.cpp.o' failed
make[2]: *** [CudaLight/CMakeFiles/HostRoutines.dir/HostRoutines/BufferInitializer.cpp.o] Error 1
CMakeFiles/Makefile2:1421: recipe for target 'CudaLight/CMakeFiles/HostRoutines.dir/all' failed
make[1]: *** [CudaLight/CMakeFiles/HostRoutines.dir/all] Error 2
Makefile:165: recipe for target 'all' failed
make: *** [all] Error 2

I think this problem could be solved by including the compiler flag "-Werror=suggest-override" but I don't know how to implement this change, nor do I understand the issue.

Can you advise?

thanks!

[pmontalb]

It looks like I missed the override keyword I'm those methods. When I have time I'll try to compile it and see if there's any other issue