Skip to content

Commit 497de7e

Browse files
author
amiya
committed
Fix test cleanup to handle locked Tantivy index files
Use temporary directories for concurrent tests and ignore errors when cleaning up locked files. Add proper try/finally blocks to ensure cleanup always runs.
1 parent 59dd50a commit 497de7e

File tree

4 files changed

+277
-265
lines changed

4 files changed

+277
-265
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,4 @@ Thumbs.db
4646

4747
# Documentation build
4848
docs/_build/
49+
test_hybrid_db/text_index/.tmpPj5j0r

tests/test_advanced_filters.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#!/usr/bin/env python3
22
"""Test advanced metadata filtering"""
33

4+
import os
45
import random
56
import shutil
67
import tempfile
@@ -228,12 +229,10 @@ def test_advanced_filters():
228229
print(" ✓ Multiple filters (implicit AND)")
229230

230231
finally:
231-
# Cleanup
232-
shutil.rmtree(temp_dir)
233-
print(f"\nCleaned up: {temp_dir}")
234-
235-
shutil.rmtree(temp_dir)
236-
print(f"\nCleaned up: {temp_dir}")
232+
# Cleanup - ignore errors from locked Tantivy index files
233+
if os.path.exists(temp_dir):
234+
shutil.rmtree(temp_dir, ignore_errors=True)
235+
print(f"\nCleaned up: {temp_dir}")
237236

238237
if __name__ == "__main__":
239238
test_advanced_filters()

0 commit comments

Comments
 (0)