Skip to content

Commit 9cd1b54

Browse files
committed
Fix after rebase
1 parent baf3419 commit 9cd1b54

1 file changed

Lines changed: 7 additions & 13 deletions

File tree

plugwise/common.py

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -205,12 +205,16 @@ def _get_groups(self) -> None:
205205
return
206206

207207
for group in self.data.group:
208+
members: list[str] = []
208209
if not group.appliances:
209210
continue
210211

211-
group_name = group.find("name").text
212-
group_type = group.find("type").text
213-
if group_type in GROUP_TYPES:
212+
for item in group.appliances.appliance:
213+
# Check if members are not orphaned - stretch
214+
if item.id in self.gw_entities:
215+
members.append(item.id)
216+
217+
if group.type in GROUP_TYPES and members and group.id:
214218
self.gw_entities[group.id] = {
215219
"dev_class": group.type,
216220
"model": "Group",
@@ -220,16 +224,6 @@ def _get_groups(self) -> None:
220224
}
221225
self._count += 5
222226

223-
def _collect_members(self, element: etree.Element) -> list[str]:
224-
"""Check and collect members."""
225-
members: list[str] = []
226-
group_appliances = element.findall("appliances/appliance")
227-
for item in group_appliances:
228-
if (member_id := item.get("id")) in self.gw_entities:
229-
members.append(member_id)
230-
231-
return members
232-
233227
def _get_lock_state(
234228
self, xml: etree.Element, data: GwEntityData, stretch_v2: bool = False
235229
) -> None:

0 commit comments

Comments
 (0)