From 70ce529420cf046a14aaf5a6c0f5dd2048a0ad22 Mon Sep 17 00:00:00 2001 From: Stanislas Kita Date: Mon, 1 Dec 2025 09:25:18 +0100 Subject: [PATCH 1/4] Fix(Tab): fix form for --- CHANGELOG.md | 2 ++ templates/forms/tab_container.html.twig | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 11524b62..24ab3c89 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ## [Unreleased] +- Fix form `path` for `tab` `container` + ## [1.23.1] - 2025-11-20 - Fix `add` operations when a linked object already exists before the plugin container fields are created. diff --git a/templates/forms/tab_container.html.twig b/templates/forms/tab_container.html.twig index 1be8116e..c041fac7 100644 --- a/templates/forms/tab_container.html.twig +++ b/templates/forms/tab_container.html.twig @@ -33,7 +33,7 @@
{% if canedit %} -
+ From 4b172dafe0bc82b334e520fa9c6575e901d4ed96 Mon Sep 17 00:00:00 2001 From: "Romain B." <8530352+Rom1-B@users.noreply.github.com> Date: Mon, 1 Dec 2025 09:39:45 +0100 Subject: [PATCH 2/4] Apply suggestion from @Rom1-B --- templates/forms/tab_container.html.twig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/forms/tab_container.html.twig b/templates/forms/tab_container.html.twig index c041fac7..40dc850a 100644 --- a/templates/forms/tab_container.html.twig +++ b/templates/forms/tab_container.html.twig @@ -33,7 +33,7 @@
{% if canedit %} - + From 504cc0e7c225bde972c35691c0b4d827966db96d Mon Sep 17 00:00:00 2001 From: Rom1-B Date: Mon, 1 Dec 2025 09:46:01 +0100 Subject: [PATCH 3/4] fix tests --- tests/QuestionTypeTestCase.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/QuestionTypeTestCase.php b/tests/QuestionTypeTestCase.php index b6f9b385..87a8ee80 100644 --- a/tests/QuestionTypeTestCase.php +++ b/tests/QuestionTypeTestCase.php @@ -30,9 +30,9 @@ namespace GlpiPlugin\Field\Tests; -use DbTestCase; use Glpi\Controller\Form\RendererController; use Glpi\Form\Form; +use Glpi\Tests\DbTestCase; use Glpi\Tests\FormTesterTrait; use PluginFieldsContainer; use PluginFieldsField; From 6750c6a1dc4a520da8a3e41431f9f73a52ad6096 Mon Sep 17 00:00:00 2001 From: Stanislas Kita Date: Mon, 1 Dec 2025 09:58:55 +0100 Subject: [PATCH 4/4] fix tu --- tests/Units/FieldDestinationFieldTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Units/FieldDestinationFieldTest.php b/tests/Units/FieldDestinationFieldTest.php index c65329e6..9f7805d7 100644 --- a/tests/Units/FieldDestinationFieldTest.php +++ b/tests/Units/FieldDestinationFieldTest.php @@ -36,6 +36,7 @@ use Glpi\Form\Destination\FormDestinationProblem; use Glpi\Form\Form; use Glpi\Form\QuestionType\QuestionTypeShortText; +use Glpi\Tests\AbstractDestinationFieldTest; use Glpi\Tests\FormBuilder; use Glpi\Tests\FormTesterTrait; use GlpiPlugin\Field\Tests\FieldTestTrait; @@ -46,7 +47,6 @@ use PluginFieldsDestinationField; use PluginFieldsQuestionType; use Problem; -use tests\units\Glpi\Form\Destination\CommonITILField\AbstractDestinationFieldTest; use Ticket; use User;