fix(Type): search option construction

Author: btry

src/EmbodiedImpact.php

@@ -85,15 +85,15 @@ public function rawSearchOptions()
         ];
 
         $id = 5;
-        foreach (Type::getImpactTypes() as $type => $unit) {
+        foreach (Type::getImpactTypes() as $type) {
             $tab[] = [
                 'id'                 => $id,
                 'table'              => $this->getTable(),
                 'field'              => $type,
                 'name'               => Type::getEmbodiedImpactLabel($type),
                 'massiveaction'      => false,
                 'datatype'           => 'number',
-                'unit'               => implode(' ', $unit),
+                'unit'               => implode(' ', Type::getImpactUnit($type)),
             ];
             $id++;
         }

src/Impact/Type.php

@@ -35,8 +35,8 @@
 
 class Type
 {
-    const IMPACT_GWP    = 0; // Global warming potential
-    const IMPACT_ADP    = 1; // Abiotic Depletion Potential
+    const IMPACT_GWP    = 1; // Global warming potential
+    const IMPACT_ADP    = 2; // Abiotic Depletion Potential
     const IMPACT_PE     = 3; // Primary Energy
     const IMPACT_GWPPB  = 4;
     const IMPACT_GWPPF  = 5;
@@ -114,7 +114,7 @@ class Type
     ];
 
     /**
-     * Undocumented function
+     * get an array of impact types
      *
      * @return array<string, array>
      */