fix latest clippy issues

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>

Author: andrei-ng

examples/custom_controls/src/main.rs

@@ -280,7 +280,7 @@ fn sinusoidal_slider_example(show: bool, file_name: &str) {
                 Visible::False
             }) // Make 10th trace visible
             .line(plotly::common::Line::new().color("#00CED1").width(6.0))
-            .name(format!("ν = {:.1}", frequency));
+            .name(format!("ν = {frequency:.1}"));
         plot.add_trace(trace);
     }
 
@@ -291,12 +291,11 @@ fn sinusoidal_slider_example(show: bool, file_name: &str) {
         let mut visible = vec![Visible::False; num_steps];
         visible[i] = Visible::True;
         let step = SliderStepBuilder::new()
-            .label(format!("step-{}", i))
-            .value(format!("{:.1}", frequency))
+            .label(format!("step-{i}"))
+            .value(format!("{frequency:.1}"))
             .push_restyle(Scatter::<f64, f64>::modify_visible(visible))
             .push_relayout(Layout::modify_title(format!(
-                "Slider switched to step: {}",
-                i
+                "Slider switched to step: {i}"
             )))
             .build()
             .unwrap();
@@ -389,12 +388,11 @@ fn gdp_life_expectancy_slider_example(show: bool, file_name: &str) {
             visible[start..end].fill(Visible::True);
 
             SliderStepBuilder::new()
-                .label(format!("year = {}", year))
+                .label(format!("year = {year}"))
                 .value(year)
                 .push_restyle(Scatter::<f64, f64>::modify_visible(visible))
                 .push_relayout(Layout::modify_title(format!(
-                    "GDP vs. Life Expectancy ({})",
-                    year
+                    "GDP vs. Life Expectancy ({year})"
                 )))
                 .build()
                 .unwrap()

examples/customization/src/main.rs

@@ -49,7 +49,7 @@ fn multiple_plots_on_same_html_page(show: bool, file_name: &str) {
         .to_html_string();
 
     std::fs::create_dir_all("./output").unwrap();
-    let path = format!("./output/inline_{}.html", file_name);
+    let path = format!("./output/inline_{file_name}.html");
     let mut file = File::create(&path).unwrap();
     file.write_all(html.as_bytes())
         .expect("failed to write html output");

examples/plotly_utils/src/lib.rs

@@ -18,10 +18,10 @@ pub fn write_example_to_html(plot: &Plot, name: &str) -> String {
     std::fs::create_dir_all("./output").unwrap();
     // Write inline HTML
     let html = plot.to_inline_html(Some(name));
-    let path = format!("./output/inline_{}.html", name);
+    let path = format!("./output/inline_{name}.html");
     std::fs::write(path, html).unwrap();
     // Write standalone HTML
-    let path = format!("./output/{}.html", name);
+    let path = format!("./output/{name}.html");
     plot.write_html(&path);
     path
 }

examples/subplots/src/main.rs

@@ -360,16 +360,16 @@ fn many_subplots_with_titles(show: bool, file_name: &str) {
         plot.add_trace(
             trace1
                 .clone()
-                .y_axis(format!("y{}", i))
-                .x_axis(format!("x{}", i)),
+                .y_axis(format!("y{i}"))
+                .x_axis(format!("x{i}")),
         );
         layout.add_annotation(
             Annotation::new()
-                .y_ref(format!("y{} domain", i))
+                .y_ref(format!("y{i} domain"))
                 .y_anchor(Anchor::Bottom)
                 .y(1)
-                .text(format!("Title {}", i))
-                .x_ref(format!("x{} domain", i))
+                .text(format!("Title {i}"))
+                .x_ref(format!("x{i} domain"))
                 .x_anchor(Anchor::Center)
                 .x(0.5)
                 .show_arrow(false),

plotly/src/layout/mod.rs

@@ -65,19 +65,19 @@ impl std::fmt::Display for ControlBuilderError {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
             ControlBuilderError::RestyleSerializationError(e) => {
-                write!(f, "Failed to serialize restyle: {}", e)
+                write!(f, "Failed to serialize restyle: {e}")
             }
             ControlBuilderError::RelayoutSerializationError(e) => {
-                write!(f, "Failed to serialize relayout: {}", e)
+                write!(f, "Failed to serialize relayout: {e}")
             }
             ControlBuilderError::ValueSerializationError(e) => {
-                write!(f, "Failed to serialize value: {}", e)
+                write!(f, "Failed to serialize value: {e}")
             }
             ControlBuilderError::InvalidRestyleObject(s) => {
-                write!(f, "Invalid restyle object: expected object but got {}", s)
+                write!(f, "Invalid restyle object: expected object but got {s}")
             }
             ControlBuilderError::InvalidRelayoutObject(s) => {
-                write!(f, "Invalid relayout object: expected object but got {}", s)
+                write!(f, "Invalid relayout object: expected object but got {s}")
             }
         }
     }

plotly/src/plot.rs

@@ -256,7 +256,7 @@ impl Plot {
         let mut temp = env::temp_dir();
         let mut plot_name = Alphanumeric.sample_string(&mut rng(), 22);
         plot_name.push_str(".html");
-        plot_name = format!("plotly_{}", plot_name);
+        plot_name = format!("plotly_{plot_name}");
         temp.push(plot_name);
 
         // Save the rendered plot to the temp file.
@@ -298,7 +298,7 @@ impl Plot {
         let mut temp = env::temp_dir();
         let mut plot_name = Alphanumeric.sample_string(&mut rng(), 22);
         plot_name.push_str(".html");
-        plot_name = format!("plotly_{}", plot_name);
+        plot_name = format!("plotly_{plot_name}");
         temp.push(plot_name);
 
         // Save the rendered plot to the temp file.
@@ -372,18 +372,14 @@ impl Plot {
     /// Display plot in Jupyter Notebook.
     pub fn notebook_display(&self) {
         let plot_data = self.to_jupyter_notebook_html();
-        println!(
-            "EVCXR_BEGIN_CONTENT text/html\n{}\nEVCXR_END_CONTENT",
-            plot_data
-        );
+        println!("EVCXR_BEGIN_CONTENT text/html\n{plot_data}\nEVCXR_END_CONTENT");
     }
 
     /// Display plot in Jupyter Lab.
     pub fn lab_display(&self) {
         let plot_data = self.to_json();
         println!(
-            "EVCXR_BEGIN_CONTENT application/vnd.plotly.v1+json\n{}\nEVCXR_END_CONTENT",
-            plot_data
+            "EVCXR_BEGIN_CONTENT application/vnd.plotly.v1+json\n{plot_data}\nEVCXR_END_CONTENT"
         );
     }
 

plotly_derive/src/field_setter.rs

@@ -10,7 +10,7 @@ pub(crate) fn field_setter_impl(input: DeriveInput) -> proc_macro::TokenStream {
         Ok(r) => r,
         Err(e) => {
             return proc_macro::TokenStream::from(
-                darling::Error::custom(format!("{}. {}", UNSUPPORTED_ERROR, e)).write_errors(),
+                darling::Error::custom(format!("{UNSUPPORTED_ERROR}. {e}")).write_errors(),
             )
         }
     };
@@ -263,8 +263,7 @@ impl FieldReceiver {
                 // Require a default
                 assert!(
                     self.default.is_some(),
-                    "Please provide #[field_setter(default=\"..\") for the field {}",
-                    field_ident
+                    "Please provide #[field_setter(default=\"..\") for the field {field_ident}"
                 );
                 let val: proc_macro2::TokenStream = self.default.as_ref().unwrap().parse().unwrap();
                 quote![
@@ -380,7 +379,7 @@ impl FieldReceiver {
                     }
                 }
                 let variant_name = Ident::new(
-                    &format!("Modify{}", variant_name),
+                    &format!("Modify{variant_name}"),
                     proc_macro2::Span::call_site(),
                 );
                 let serde_attrs = self.serde();
@@ -425,13 +424,13 @@ impl FieldReceiver {
         }) = &modify_enum
         {
             let modify_ident = Ident::new(
-                &format!("modify_{}", field_ident),
+                &format!("modify_{field_ident}"),
                 proc_macro2::Span::call_site(),
             );
             match kind {
                 Kind::Trace => {
                     let modify_all_ident = Ident::new(
-                        &format!("modify_all_{}", field_ident),
+                        &format!("modify_all_{field_ident}"),
                         proc_macro2::Span::call_site(),
                     );
 
@@ -467,7 +466,7 @@ impl FieldReceiver {
         let array_setter = match field_type {
             FieldType::OptionDimString | FieldType::OptionDimOther(..) => {
                 let array_ident = Ident::new(
-                    &format!("{}_array", field_ident),
+                    &format!("{field_ident}_array"),
                     proc_macro2::Span::call_site(),
                 );
                 quote! {

plotly_kaleido/build.rs

@@ -44,12 +44,12 @@ fn extract_zip(p: &Path, zip_file: &Path) -> Result<()> {
         let mut file = archive.by_index(i).unwrap();
         let outpath = file.mangled_name();
         let outpath = p.join(outpath);
-        println!("outpath: {:?}", outpath);
+        println!("outpath: {outpath:?}");
 
         {
             let comment = file.comment();
             if !comment.is_empty() {
-                println!("File {} comment: {}", i, comment);
+                println!("File {i} comment: {comment}");
             }
         }
 

plotly_kaleido/src/lib.rs

@@ -98,7 +98,7 @@ impl Kaleido {
 
         let path = match Kaleido::binary_path(&path) {
             Ok(kaleido_path) => kaleido_path,
-            Err(msg) => panic!("Failed tu use Kaleido binary at {} due to {}", path, msg),
+            Err(msg) => panic!("Failed tu use Kaleido binary at {path} due to {msg}"),
         };
 
         Kaleido { cmd_path: path }
@@ -244,7 +244,7 @@ impl Kaleido {
         let stderr_lines = BufReader::new(stderr).lines();
         for line in stderr_lines {
             let line = line.unwrap();
-            eprintln!("{}", line);
+            eprintln!("{line}");
         }
 
         Ok(String::default())