Merge pull request #3308 from plotly/issue-3302_revision

Bug fix - adjust tick distances in perspective views

Author: archmoj

package-lock.json

@@ -78,7 +78,7 @@
     "gl-mat4": "^1.2.0",
     "gl-mesh3d": "^2.0.2",
     "gl-plot2d": "^1.4.0",
-    "gl-plot3d": "^1.6.0",
+    "gl-plot3d": "^1.6.1",
     "gl-pointcloud2d": "^1.0.1",
     "gl-scatter3d": "^1.1.0",
     "gl-select-box": "^1.0.2",

package.json

@@ -0,0 +1,29 @@
+{
+	"data":[
+		{
+			"type": "surface",
+            "contours": {
+                "x": {"show": true},
+                "y": {"show": true},
+                "z": {"show": false}
+            },
+            "x": [0, 4],
+            "y": [0, 1, 2, 3, 4],
+			"z": [[0, 0], [0, 0], [0, 1], [1, 1], [1, 1]]
+		}
+	],
+    "layout": {
+        "title": "Tick distances and contour lines in perspective view.",
+        "width": 1000,
+        "height": 500,
+        "scene": {
+            "xaxis": {"nticks": 32},
+            "yaxis": {"nticks": 32},
+            "camera": {
+                "center": {"x": 0, "y": 0.25, "z": 0.0},
+                "eye": {"x": 0.75, "y": 0.25, "z": 0.25},
+                "up": {"x": 0, "y": 0, "z": 1}
+            }
+        }
+    }
+}

test/image/baselines/gl3d_perspective_tick_distances.png

@@ -714,15 +714,15 @@ describe('Test gl3d plots', function() {
         .then(done);
     });
 
-    it('@gl axis ticks should not be set when axis _length is NaN', function(done) {
+    it('@gl should not set _length to NaN and dtick should be defined.', function(done) {
         Plotly.plot(gd,
             {
                 data: [{
                     type: 'scatter3d',
                     mode: 'markers',
                     x: [1, 2],
                     y: [3, 4],
-                    z: [5, 6]
+                    z: [0.000000005, 0.000000006]
                 }],
                 layout: {
                     scene: {
@@ -737,8 +737,8 @@ describe('Test gl3d plots', function() {
         )
         .then(function() {
             var zaxis = gd._fullLayout.scene.zaxis;
-            expect(isNaN(zaxis._length)).toBe(true);
-            expect(zaxis.dtick === undefined).toBe(true);
+            expect(isNaN(zaxis._length)).toBe(false);
+            expect(zaxis.dtick === undefined).toBe(false);
         })
         .catch(failTest)
         .then(done);