fix issue 2862 by showing colorbar when scatter line has scale e.g. scatter3d case

Author: archmoj

src/components/colorbar/connect.js

@@ -41,19 +41,24 @@ module.exports = function connectColorbar(gd, cd, moduleOpts) {
 
     var trace = cd[0].trace;
     var cbId = 'cb' + trace.uid;
-    var containerName = moduleOpts.container;
-    var container = containerName ? trace[containerName] : trace;
+    var containerNames = moduleOpts.container.split(' | ');
 
-    gd._fullLayout._infolayer.selectAll('.' + cbId).remove();
-    if(!container || !container.showscale) return;
+    for(var i = 0; i < containerNames.length; i++) {
+        var containerName = containerNames[i];
 
-    var cb = cd[0].t.cb = drawColorbar(gd, cbId);
+        var container = containerName ? trace[containerName] : trace;
 
-    var scl = container.reversescale ?
-        flipScale(container.colorscale) :
-        container.colorscale;
+        gd._fullLayout._infolayer.selectAll('.' + cbId).remove();
+        if(!container || !container.showscale) continue;
 
-    cb.fillgradient(scl)
-        .zrange([container[moduleOpts.min], container[moduleOpts.max]])
-        .options(container.colorbar)();
+        var cb = cd[0].t.cb = drawColorbar(gd, cbId);
+
+        var scl = container.reversescale ?
+            flipScale(container.colorscale) :
+            container.colorscale;
+
+        cb.fillgradient(scl)
+            .zrange([container[moduleOpts.min], container[moduleOpts.max]])
+            .options(container.colorbar)();
+    }
 };

src/traces/scatter/line_defaults.js

@@ -18,7 +18,7 @@ module.exports = function lineDefaults(traceIn, traceOut, defaultColor, layout,
     coerce('line.color', defaultColor);
 
     if(hasColorscale(traceIn, 'line')) {
-        colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: 'line.', cLetter: 'c', noScale: true});
+        colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: 'line.', cLetter: 'c'});
     } else {
         var lineColorDflt = (isArrayOrTypedArray(markerColor) ? false : markerColor) || defaultColor;
         coerce('line.color', lineColorDflt);

src/traces/scatter/marker_colorbar.js

@@ -10,7 +10,7 @@
 'use strict';
 
 module.exports = {
-    container: 'marker',
+    container: 'marker | line',
     min: 'cmin',
     max: 'cmax'
 };

src/traces/scatter3d/attributes.js

@@ -31,9 +31,6 @@ var lineAttrs = extendFlat({
         description: 'Sets the dash style of the lines.'
     }
 }, colorAttributes('line'));
-// not yet implemented
-delete lineAttrs.showscale;
-delete lineAttrs.colorbar;
 
 function makeProjectionAttr(axLetter) {
     return {