Pass back update data unmodified to plotly_relayout event handlers [882]

- ... even if deprecated layout attributes have been cleaned up
  internally.
- Reason: to stay backwards-compatible with existing event handlers
  that count on the old titles structure for example.

Author: rmoestl

src/plot_api/plot_api.js

@@ -1859,6 +1859,7 @@ function _relayout(gd, aobj) {
     var layout = gd.layout,
         fullLayout = gd._fullLayout,
         axes = Axes.list(gd),
+        eventData = Lib.extendDeepAll({}, aobj),
         arrayEdits = {},
         keys,
         arrayStr,
@@ -2194,7 +2195,7 @@ function _relayout(gd, aobj) {
         rangesAltered: rangesAltered,
         undoit: undoit,
         redoit: redoit,
-        eventData: Lib.extendDeep({}, redoit)
+        eventData: eventData
     };
 }
 

test/jasmine/tests/legend_test.js

@@ -1431,7 +1431,7 @@ describe('legend interaction', function() {
                     });
                     gd.on('plotly_relayout', function(d) {
                         expect(typeof d).toBe('object');
-                        expect(d.title.text).toBe('just clicked on trace #2');
+                        expect(d.title).toBe('just clicked on trace #2');
                         done();
                     });
                     gd.on('plotly_restyle', function() {
@@ -1451,7 +1451,7 @@ describe('legend interaction', function() {
                     });
                     gd.on('plotly_relayout', function(d) {
                         expect(typeof d).toBe('object');
-                        expect(d.title.text).toBe('just double clicked on trace #0');
+                        expect(d.title).toBe('just double clicked on trace #0');
                         done();
                     });
                     gd.on('plotly_restyle', function() {

test/jasmine/tests/plot_api_test.js

@@ -547,6 +547,30 @@ describe('Test plot api', function() {
             .catch(failTest)
             .then(done);
         });
+
+        it('passes update data back to plotly_relayout unmodified ' +
+          'even if deprecated attributes have been used', function(done) {
+            Plotly.newPlot(gd, [{y: [1, 3, 2]}]);
+
+            gd.on('plotly_relayout', function(eventData) {
+                expect(eventData).toEqual({
+                    'title': 'Plotly chart',
+                    'xaxis.title': 'X',
+                    'xaxis.titlefont': {color: 'green'},
+                    'yaxis.title': 'Y',
+                    'polar.radialaxis.title': 'Radial'
+                });
+                done();
+            });
+
+            Plotly.relayout(gd, {
+                'title': 'Plotly chart',
+                'xaxis.title': 'X',
+                'xaxis.titlefont': {color: 'green'},
+                'yaxis.title': 'Y',
+                'polar.radialaxis.title': 'Radial'
+            });
+        });
     });
 
     describe('Plotly.relayout subroutines switchboard', function() {