do not coerce choropleth* marker.line.color

... when marker.line.width===0

Author: etpinard

src/traces/choropleth/defaults.js

@@ -25,6 +25,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         traceOut.visible = false;
         return;
     }
+
     traceOut._length = Math.min(locations.length, z.length);
 
     coerce('locationmode');
@@ -33,13 +34,11 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     coerce('hovertext');
     coerce('hovertemplate');
 
-    coerce('marker.line.color');
-    coerce('marker.line.width');
+    var mlw = coerce('marker.line.width');
+    if(mlw) coerce('marker.line.color');
     coerce('marker.opacity');
 
-    colorscaleDefaults(
-        traceIn, traceOut, layout, coerce, {prefix: '', cLetter: 'z'}
-    );
+    colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: '', cLetter: 'z'});
 
     Lib.coerceSelectionMarkerOpacity(traceOut, coerce);
 };

src/traces/choroplethmapbox/defaults.js

@@ -37,8 +37,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     coerce('hovertext');
     coerce('hovertemplate');
 
-    coerce('marker.line.color');
-    coerce('marker.line.width');
+    var mlw = coerce('marker.line.width');
+    if(mlw) coerce('marker.line.color');
     coerce('marker.opacity');
 
     colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: '', cLetter: 'z'});

test/jasmine/tests/choropleth_test.js

@@ -71,6 +71,23 @@ describe('Test choropleth', function() {
             Choropleth.supplyDefaults(traceIn, traceOut, defaultColor, layout);
             expect(traceOut.visible).toBe(false);
         });
+
+        it('should not coerce *marker.line.color* when *marker.line.width* is *0*', function() {
+            traceIn = {
+                locations: ['CAN', 'USA'],
+                z: [1, 2],
+                marker: {
+                    line: {
+                        color: 'red',
+                        width: 0
+                    }
+                }
+            };
+
+            Choropleth.supplyDefaults(traceIn, traceOut, defaultColor, layout);
+            expect(traceOut.marker.line.width).toBe(0, 'mlw');
+            expect(traceOut.marker.line.color).toBe(undefined, 'mlc');
+        });
     });
 });
 

test/jasmine/tests/choroplethmapbox_test.js

@@ -72,6 +72,23 @@ describe('Test choroplethmapbox defaults:', function() {
         ]);
         expectVisibleFalse();
     });
+
+    it('should not coerce *marker.line.color* when *marker.line.width* is *0*', function() {
+        _supply([{
+            locations: ['CAN', 'USA'],
+            z: [1, 2],
+            geojson: 'url',
+            marker: {
+                line: {
+                    color: 'red',
+                    width: 0
+                }
+            }
+        }]);
+
+        expect(fullData[0].marker.line.width).toBe(0, 'mlw');
+        expect(fullData[0].marker.line.color).toBe(undefined, 'mlc');
+    });
 });
 
 describe('Test choroplethmapbox convert:', function() {