remove references to transforms in comments, and some additional unneeded code

Author: emilykl

src/lib/index.js

@@ -910,8 +910,8 @@ lib.expandObjectPaths = function (data) {
                     data[prop] = data[prop] || [];
 
                     if (match[3] === '.') {
-                        // This is the case where theere are subsequent properties into which
-                        // we must recurse, e.g. transforms[0].value
+                        // This is the case where there are subsequent properties into which
+                        // we must recurse, e.g. annotations[0].text
                         trailingPath = match[4];
                         dest = data[prop][idx] = data[prop][idx] || {};
 

src/plot_api/plot_api.js

@@ -1408,16 +1408,6 @@ function _restyle(gd, aobj, traces) {
         return 'LAYOUT' + axName + '.range';
     }
 
-    function getFullTrace(traceIndex) {
-        // usually fullData maps 1:1 onto data, but with groupby transforms
-        // the fullData index can be greater. Take the *first* matching trace.
-        for (var j = traceIndex; j < fullData.length; j++) {
-            if (fullData[j]._input === data[traceIndex]) return fullData[j];
-        }
-        // should never get here - and if we *do* it should cause an error
-        // later on undefined fullTrace is passed to nestedProperty.
-    }
-
     // for attrs that interact (like scales & autoscales), save the
     // old vals before making the change
     // val=undefined will not set a value, just record what the value was.
@@ -1438,7 +1428,7 @@ function _restyle(gd, aobj, traces) {
             extraparam = layoutNP(gd.layout, attr.replace('LAYOUT', ''));
         } else {
             var tracei = traces[i];
-            var preGUI = fullLayout._tracePreGUI[getFullTrace(tracei).uid];
+            var preGUI = fullLayout._tracePreGUI[fullData[tracei].uid];
             extraparam = makeNP(preGUI, guiEditFlag)(data[tracei], attr);
         }
 
@@ -1509,7 +1499,7 @@ function _restyle(gd, aobj, traces) {
         undoit[ai] = a0();
         for (i = 0; i < traces.length; i++) {
             cont = data[traces[i]];
-            contFull = getFullTrace(traces[i]);
+            contFull = fullData[traces[i]];
             var preGUI = fullLayout._tracePreGUI[contFull.uid];
             param = makeNP(preGUI, guiEditFlag)(cont, ai);
             oldVal = param.get();
@@ -2343,8 +2333,7 @@ var layoutUIControlPatterns = [
 // or with no `attr` we use `trace.uirevision`
 var traceUIControlPatterns = [
     { pattern: /^selectedpoints$/, attr: 'selectionrevision' },
-    // "visible" includes trace.transforms[i].styles[j].value.visible
-    { pattern: /(^|value\.)visible$/, attr: 'legend.uirevision' },
+    { pattern: /^visible$/, attr: 'legend.uirevision' },
     { pattern: /^dimensions\[\d+\]\.constraintrange/ },
     { pattern: /^node\.(x|y|groups)/ }, // for Sankey nodes
     { pattern: /^level$/ }, // for Sunburst, Treemap and Icicle traces
@@ -2354,8 +2343,7 @@ var traceUIControlPatterns = [
     // reasonable or should these be `editrevision`?
     // Also applies to axis titles up in the layout section
 
-    // "name" also includes transform.styles
-    { pattern: /(^|value\.)name$/ },
+    { pattern: /^name$/ },
     // including nested colorbar attributes (ie marker.colorbar)
     { pattern: /colorbar\.title\.text$/ },
     { pattern: /colorbar\.(x|y)$/, attr: 'editrevision' }

src/plot_api/plot_schema.js

@@ -218,7 +218,7 @@ exports.findArrayAttributes = function(trace) {
  * @param {object} trace
  *  full trace object that contains a reference to `_module.attributes`
  * @param {object} parts
- *  an array of parts, like ['transforms', 1, 'value']
+ *  an array of parts, like ['dimensions', 1, 'values']
  *  typically from nestedProperty(...).parts
  *
  * @return {object|false}

src/plot_api/template_api.js

@@ -49,8 +49,6 @@ exports.makeTemplate = function(figure) {
     data.forEach(function(trace) {
         // TODO: What if no style info is extracted for this trace. We may
         // not want an empty object as the null value.
-        // TODO: allow transforms to contribute to templates?
-        // as it stands they are ignored, which may be for the best...
 
         var traceTemplate = {};
         walkStyleKeys(trace, traceTemplate, getTraceInfo.bind(null, trace));

src/plots/get_data.js

@@ -65,7 +65,7 @@ exports.getModuleCalcData = function(calcdata, arg1, arg2) {
         var filterByZ = (trace.zorder !== undefined);
         // N.B.
         // - 'legendonly' traces do not make it past here
-        // - skip over 'visible' traces that got trimmed completely during calc transforms
+        // - skip over 'visible' traces with no data points
         if(trace.visible !== true || trace._length === 0) continue;
 
         // group calcdata trace not by 'module' (as the name of this function

src/plots/plots.js

@@ -2232,7 +2232,7 @@ plots.layoutArrayContainers = Registry.layoutArrayContainers;
  * Extend a trace definition. This method:
  *
  *  1. directly transfers any array references
- *  2. manually recurses into container arrays like transforms
+ *  2. manually recurses into container arrays like dimensions
  *
  * The result is the original object reference with the new contents merged in.
  */

src/traces/cone/defaults.js

@@ -63,6 +63,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     coerce('yhoverformat');
     coerce('zhoverformat');
 
-    // disable 1D transforms (for now)
+    // Ensure _length is defined
     traceOut._length = null;
 };

src/traces/contour/constraint_mapping.js

@@ -3,8 +3,9 @@
 var filterOps = require('../../constants/filter_ops');
 var isNumeric = require('fast-isnumeric');
 
-// This syntax conforms to the existing filter transform syntax, but we don't care
-// about open vs. closed intervals for simply drawing contours constraints:
+// This syntax uses the comparison and interval operations defined in
+// src/constants/filter_ops.js, but we don't care about open vs. closed intervals
+// for the purpose of drawing contours constraints
 module.exports = {
     '[]': makeRangeSettings('[]'),
     '][': makeRangeSettings(']['),
@@ -13,8 +14,7 @@ module.exports = {
     '=': makeInequalitySettings('=')
 };
 
-// This does not in any way shape or form support calendars. It's adapted from
-// transforms/filter.js.
+// This does not in any way shape or form support calendars
 function coerceValue(operation, value) {
     var hasArrayValue = Array.isArray(value);
 

src/traces/icicle/defaults.js

@@ -95,6 +95,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
 
     handleDomainDefaults(traceOut, layout, coerce);
 
-    // do not support transforms for now
+    // Ensure _length is defined
     traceOut._length = null;
 };

src/traces/indicator/defaults.js

@@ -146,7 +146,7 @@ function supplyDefaults(traceIn, traceOut, defaultColor, layout) {
         traceOut._isAngular = traceOut._isBullet = false;
     }
 
-    // disable 1D transforms
+    // Ensure _length is defined
     traceOut._length = null;
 }