remove layout.hidesources attr

emilykl · emilykl · commit 2bc318fee18b · 2026-06-08T17:55:38.000-04:00
diff --git a/src/plots/layout_attributes.js b/src/plots/layout_attributes.js
@@ -318,17 +318,6 @@ module.exports = {
             'other locales may alter this default.'
         ].join(' ')
     },
-    hidesources: {
-        valType: 'boolean',
-        dflt: false,
-        editType: 'plot',
-        description: [
-            'Determines whether or not a text link citing the data source is',
-            'placed at the bottom-right cored of the figure.',
-            'Has only an effect only on graphs that have been generated via',
-            'forked graphs from the Chart Studio Cloud (at https://chart-studio.plotly.com or on-premise).'
-        ].join(' ')
-    },
     showlegend: {
         // handled in legend.supplyLayoutDefaults
         // but included here because it's not in the legend object
diff --git a/src/plots/plots.js b/src/plots/plots.js
@@ -1318,7 +1318,6 @@ plots.supplyLayoutGlobalDefaults = function(layoutIn, layoutOut, formatObj) {
     coerce('paper_bgcolor');
 
     coerce('separators', formatObj.decimal + formatObj.thousands);
-    coerce('hidesources');
 
     coerce('colorway');
 
diff --git a/src/snapshot/cloneplot.js b/src/snapshot/cloneplot.js
@@ -26,7 +26,6 @@ function cloneLayoutOverride(tileClass) {
         case 'thumbnail':
             override = {
                 title: {text: ''},
-                hidesources: true,
                 showlegend: false,
                 borderwidth: 0,
                 bordercolor: '',
diff --git a/src/types/generated/schema.d.ts b/src/types/generated/schema.d.ts
@@ -16254,7 +16254,6 @@ export interface Layout {
         yside?: 'left' | 'left plot' | 'right plot' | 'right';
     };
     height?: number;
-    hidesources?: boolean;
     hoveranywhere?: boolean;
     hoverdistance?: number;
     hoverlabel?: {
diff --git a/test/image/mocks/0.json b/test/image/mocks/0.json
@@ -1217,7 +1217,6 @@
     "barmode": "stack",
     "bargap": 0.2,
     "bargroupgap": 0,
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/1.json b/test/image/mocks/1.json
@@ -609,7 +609,6 @@
     "hovermode": "x",
     "dragmode": "zoom",
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/10.json b/test/image/mocks/10.json
@@ -256,7 +256,6 @@
     "plot_bgcolor": "rgb(255, 255, 255)",
     "hovermode": "x",
     "dragmode": "zoom",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/11.json b/test/image/mocks/11.json
@@ -232,7 +232,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/12.json b/test/image/mocks/12.json
@@ -505,7 +505,6 @@
     "bargroupgap": 0,
     "boxmode": "overlay",
     "separators": ".,",
-    "hidesources": false,
     "selections": [
       {
         "x0": 150,
diff --git a/test/image/mocks/13.json b/test/image/mocks/13.json
@@ -328,7 +328,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/14.json b/test/image/mocks/14.json
@@ -335,7 +335,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/15.json b/test/image/mocks/15.json
@@ -270,7 +270,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/17.json b/test/image/mocks/17.json
@@ -632,7 +632,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/18.json b/test/image/mocks/18.json
@@ -1235,7 +1235,6 @@
     "bargroupgap": 0,
     "boxmode": "overlay",
     "separators": ".,",
-    "hidesources": false,
     "yaxis2": {
       "title": {
         "text": "sepal width",
diff --git a/test/image/mocks/19.json b/test/image/mocks/19.json
@@ -153,7 +153,6 @@
     "bargroupgap": 0,
     "boxmode": "overlay",
     "separators": ".,",
-    "hidesources": false,
     "yaxis2": {
       "title": {
         "text": "Click to enter Y2 axis title"
diff --git a/test/image/mocks/21.json b/test/image/mocks/21.json
@@ -485,7 +485,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/22.json b/test/image/mocks/22.json
@@ -288,7 +288,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/23.json b/test/image/mocks/23.json
@@ -144,7 +144,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/24.json b/test/image/mocks/24.json
@@ -183,7 +183,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/25.json b/test/image/mocks/25.json
@@ -178,7 +178,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/26.json b/test/image/mocks/26.json
@@ -21207,7 +21207,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/27.json b/test/image/mocks/27.json
@@ -347,7 +347,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".",
-    "hidesources": false
+    "separators": "."
   }
 }
diff --git a/test/image/mocks/28.json b/test/image/mocks/28.json
@@ -1002,7 +1002,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".",
-    "hidesources": false
+    "separators": "."
   }
 }
diff --git a/test/image/mocks/29.json b/test/image/mocks/29.json
@@ -2284,7 +2284,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/30.json b/test/image/mocks/30.json
@@ -198,7 +198,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/31.json b/test/image/mocks/31.json
@@ -381,7 +381,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/32.json b/test/image/mocks/32.json
@@ -828,7 +828,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/4.json b/test/image/mocks/4.json
@@ -128,7 +128,6 @@
     "plot_bgcolor": "#fff",
     "hovermode": "x",
     "dragmode": "zoom",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/5.json b/test/image/mocks/5.json
@@ -184,7 +184,6 @@
     "plot_bgcolor": "#fff",
     "hovermode": "x",
     "dragmode": "zoom",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/contour_match_edges.json b/test/image/mocks/contour_match_edges.json
@@ -1926,7 +1926,6 @@
       "exponentformat": "B"
     },
     "bargroupgap": 0,
-    "hidesources": false,
     "showlegend": false,
     "separators": ".,",
     "barmode": "group",
diff --git a/test/image/mocks/fonts.json b/test/image/mocks/fonts.json
@@ -431,7 +431,6 @@
       "anchor": "x",
       "exponentformat": "B"
     },
-    "hidesources": false,
     "boxgroupgap": 0.3,
     "margin": {
       "b": 80,
diff --git a/test/image/mocks/funnel_11.json b/test/image/mocks/funnel_11.json
@@ -120,7 +120,6 @@
     "funnelmode": "group",
     "funnelgap": 0.2,
     "funnelgroupgap": 0,
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/gl2d_10.json b/test/image/mocks/gl2d_10.json
@@ -145,7 +145,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/gl2d_12.json b/test/image/mocks/gl2d_12.json
@@ -502,7 +502,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/gl2d_14.json b/test/image/mocks/gl2d_14.json
@@ -146,7 +146,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/gl2d_17.json b/test/image/mocks/gl2d_17.json
@@ -588,7 +588,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/gl2d_fonts.json b/test/image/mocks/gl2d_fonts.json
@@ -427,7 +427,6 @@
     "bargroupgap": 0,
     "boxmode": "overlay",
     "boxgap": 0.3,
-    "boxgroupgap": 0.3,
-    "hidesources": false
+    "boxgroupgap": 0.3
   }
 }
diff --git a/test/image/mocks/gl3d_opacity-surface.json b/test/image/mocks/gl3d_opacity-surface.json
@@ -1528,7 +1528,6 @@
     }
   ],
   "layout": {
-    "hidesources": false,
     "autosize": true,
     "font": {
       "color": "#444",
diff --git a/test/image/mocks/legend_horizontal.json b/test/image/mocks/legend_horizontal.json
@@ -137,7 +137,6 @@
     "bargap": 0.2,
     "bargroupgap": 0,
     "boxmode": "overlay",
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/image/mocks/text_export.json b/test/image/mocks/text_export.json
@@ -1670,7 +1670,6 @@
       "size": 12
     },
     "height": 630,
-    "hidesources": false,
     "hovermode": "x",
     "legend": {
       "x": 0.5392124763053593,
diff --git a/test/image/mocks/titles-avoid-labels.json b/test/image/mocks/titles-avoid-labels.json
@@ -140,7 +140,6 @@
     "dragmode": "zoom",
     "hovermode": "x",
     "separators": ".,",
-    "hidesources": false,
     "showlegend": false
   }
 }
diff --git a/test/image/mocks/waterfall_11.json b/test/image/mocks/waterfall_11.json
@@ -133,7 +133,6 @@
     "waterfallmode": "group",
     "waterfallgap": 0.2,
     "waterfallgroupgap": 0.1,
-    "separators": ".,",
-    "hidesources": false
+    "separators": ".,"
   }
 }
diff --git a/test/jasmine/tests/snapshot_test.js b/test/jasmine/tests/snapshot_test.js
@@ -100,7 +100,6 @@ describe('Plotly.Snapshot', function() {
 
             var THUMBNAIL_DEFAULT_LAYOUT = {
                 title: {text: ''},
-                hidesources: true,
                 showlegend: false,
                 hovermode: false,
                 dragmode: false,
@@ -112,7 +111,6 @@ describe('Plotly.Snapshot', function() {
             };
 
             var thumbTile = Plotly.Snapshot.clone(dummyGraphObj, thumbnailOptions);
-            expect(thumbTile.layout.hidesources).toEqual(THUMBNAIL_DEFAULT_LAYOUT.hidesources);
             expect(thumbTile.layout.showlegend).toEqual(THUMBNAIL_DEFAULT_LAYOUT.showlegend);
             expect(thumbTile.layout.borderwidth).toEqual(THUMBNAIL_DEFAULT_LAYOUT.borderwidth);
             expect(thumbTile.layout.annotations).toEqual(THUMBNAIL_DEFAULT_LAYOUT.annotations);
diff --git a/test/plot-schema.json b/test/plot-schema.json

Original file line number	Diff line number	Diff line change
`@@ -1217,7 +1217,6 @@`
`1217`	`1217`	`"barmode": "stack",`
`1218`	`1218`	`"bargap": 0.2,`
`1219`	`1219`	`"bargroupgap": 0,`
`1220`		`- "separators": ".,",`
`1221`		`- "hidesources": false`
	`1220`	`+ "separators": ".,"`
`1222`	`1221`	`}`
`1223`	`1222`	`}`
Original file line number	Diff line number	Diff line change
`@@ -609,7 +609,6 @@`
`609`	`609`	`"hovermode": "x",`
`610`	`610`	`"dragmode": "zoom",`
`611`	`611`	`"boxmode": "overlay",`
`612`		`- "separators": ".,",`
`613`		`- "hidesources": false`
	`612`	`+ "separators": ".,"`
`614`	`613`	`}`
`615`	`614`	`}`
Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,6 @@`
`256`	`256`	`"plot_bgcolor": "rgb(255, 255, 255)",`
`257`	`257`	`"hovermode": "x",`
`258`	`258`	`"dragmode": "zoom",`
`259`		`- "separators": ".,",`
`260`		`- "hidesources": false`
	`259`	`+ "separators": ".,"`
`261`	`260`	`}`
`262`	`261`	`}`
Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,6 @@`
`232`	`232`	`"bargap": 0.2,`
`233`	`233`	`"bargroupgap": 0,`
`234`	`234`	`"boxmode": "overlay",`
`235`		`- "separators": ".,",`
`236`		`- "hidesources": false`
	`235`	`+ "separators": ".,"`
`237`	`236`	`}`
`238`	`237`	`}`
Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,6 @@`
`505`	`505`	`"bargroupgap": 0,`
`506`	`506`	`"boxmode": "overlay",`
`507`	`507`	`"separators": ".,",`
`508`		`- "hidesources": false,`
`509`	`508`	`"selections": [`
`510`	`509`	`{`
`511`	`510`	`"x0": 150,`
Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,6 @@`
`328`	`328`	`"bargap": 0.2,`
`329`	`329`	`"bargroupgap": 0,`
`330`	`330`	`"boxmode": "overlay",`
`331`		`- "separators": ".,",`
`332`		`- "hidesources": false`
	`331`	`+ "separators": ".,"`
`333`	`332`	`}`
`334`	`333`	`}`