Skip to content

Commit 0d5911e

Browse files
committed
- fix bug: deleted files are not removed from release branch when publishing to github
- bump version
1 parent a28f748 commit 0d5911e

5 files changed

Lines changed: 29 additions & 12 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Change Logs
22

3+
## v1.4.5
4+
5+
- fix bug: deleted files are not removed from release branch when publishing to github
6+
7+
38
## v1.4.4
49

510
- support release to github with `publish -g` option

cli.js

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -480,13 +480,9 @@ makeGithubRelease = function(arg$){
480480
fsExtra.removeSync(releaseFolder);
481481
}
482482
return exec(['git', 'worktree', 'add', '--force'].concat([releaseFolder, branch])).then(function(){
483-
var cmd;
484-
fsExtra.copySync(workFolder, releaseFolder, {
485-
overwrite: true
486-
});
487-
cmd = "cd .fedep/_public && git add * && git commit -m \"regen\" && git push -u " + remote + " " + branch + " && cd .. && rm -rf _public";
488483
return new Promise(function(res, rej){
489-
return child_process.exec(cmd, function(e, sout, serr){
484+
return child_process.exec("cd " + releaseFolder + " && git rm -r *", function(e, sout, serr){
485+
var cmd;
490486
serr == null && (serr = "");
491487
if (e) {
492488
return rej(new Error([sout, serr].map(function(it){
@@ -495,7 +491,21 @@ makeGithubRelease = function(arg$){
495491
return it;
496492
}).join('\n')));
497493
}
498-
return res();
494+
fsExtra.copySync(workFolder, releaseFolder, {
495+
overwrite: true
496+
});
497+
cmd = "cd " + releaseFolder + " && git add * && git commit -m \"regen\" && git push -u " + remote + " " + branch + " && cd .. && rm -rf _public";
498+
return child_process.exec(cmd, function(e, sout, serr){
499+
serr == null && (serr = "");
500+
if (e) {
501+
return rej(new Error([sout, serr].map(function(it){
502+
return (it || '').trim();
503+
}).filter(function(it){
504+
return it;
505+
}).join('\n')));
506+
}
507+
return res();
508+
});
499509
});
500510
});
501511
});

lib/release.ls

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,11 @@ make-github-release = ({branch = "release"}) ->
8585
if !fs.exists-sync work-folder => return Promise.reject("work folder #work-folder doesn't exist")
8686
if fs.exists-sync release-folder => fs-extra.remove-sync release-folder
8787
<- exec <[git worktree add --force]> ++ [release-folder, branch] .then _
88-
fs-extra.copy-sync work-folder, release-folder, {overwrite: true}
89-
cmd = "cd .fedep/_public && git add * && git commit -m \"regen\" && git push -u #remote #branch && cd .. && rm -rf _public"
9088
(res, rej) <- new Promise _
89+
(e, sout, serr = "") <- child_process.exec "cd #release-folder && git rm -r *", _
90+
if e => return rej new Error([sout, serr].map(->(it or '').trim!).filter(->it).join(\\n))
91+
fs-extra.copy-sync work-folder, release-folder, {overwrite: true}
92+
cmd = "cd #release-folder && git add * && git commit -m \"regen\" && git push -u #remote #branch && cd .. && rm -rf _public"
9193
(e, sout, serr = "") <- child_process.exec cmd, _
9294
if e => return rej new Error([sout, serr].map(->(it or '').trim!).filter(->it).join(\\n))
9395
return res!

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"cli.js"
77
],
88
"description": "Frontend dependency installer",
9-
"version": "1.4.4",
9+
"version": "1.4.5",
1010
"homepage": "https://github.com/plotdb/fedep",
1111
"repository": {
1212
"type": "git",

0 commit comments

Comments
 (0)