Another error with google-github-actions/setup-gcloud

[parak]

Finally had a chance to test 5.46.0, which still generates an error with gcloud but adifferent one:

Run google-github-actions/setup-gcloud@v3
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/af9b9d15-5bea-462b-93b2-8876276ea1f7 -f /home/runner/work/_temp/1edb1bcc-c8f6-4b63-9c5f-9bcf5e8a842e
Error: google-github-actions/setup-gcloud failed with: failed to execute command `gcloud --quiet auth login --force --cred-file /home/runner/work/<repo>/<repo>/gha-creds-513dd5e9ec25fccc.json`: Traceback (most recent call last):
  File "<string>", line 104, in <module>
    exec('__file__="/home/runner/work/_temp/af9b9d15-5bea-462b-93b2-8876276ea1f7/google-cloud-sdk/lib/gcloud.py"\n' + file.read())
    ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 21
Syntaxfrom __future__ imports must occur at the beginning of the file

Much appreciated as always for looking into these.

[plengauer]

hmmm, i fixed one problem by setting the file variable manually, but i probably prepended a few imports that way ...

if my theory is correct, that should be easily fixable. unforrtuantely, again i cannot test directly, i can only try to reproduce the same error in custom test scripts because i dont have access to authentication for these services

[plengauer]

https://github.com/jphalip/google-cloud-sdk/blob/master/lib/gcloud.py

the __file__ is set in line 0, so destroying the shebang as well as the imports in the process. shebang is not an issue, because we are already loaded and shebang is effectively just a comment now.

[plengauer]

a quick manual test with a small python test shows this works...

the file at the link above shows no imports of style from __future__. am i looking at the wrong one?

[plengauer]

this one looks more like it: https://github.com/google-cloud-sdk-unofficial/google-cloud-sdk/blob/master/lib/gcloud.py

[plengauer]

now it reproduces:

  File "/home/ubuntu/Sandbox/tmp/gcloud.py", line 21
    from __future__ import absolute_import
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: from __future__ imports must occur at the beginning of the file

[plengauer]

fix: we have to adjust how the __file__ variable is set in the file agent.instrumentation.python.sh. if the file contains from __future__ we have to add the assignment of __file__ after the last such import. if there is none, we can just prepend it. This should be done dynamically, without modyfing the file on disk just like now.

[parak]

Thanks! This fix is included in 5.49.0 right? Hopefully I'll be able to test it in the next few days.