Skip to content

Commit 81a7af2

Browse files
sugarmanzsugarmanz
authored
Add pom.xml details (#9)
* add pom template * update maven groups for plugin implementations * fix basic plugin import
1 parent 32f108b commit 81a7af2

10 files changed

Lines changed: 59 additions & 15 deletions

File tree

‎devtools/plugins/basic/android/BUILD‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# Android lib that consumes jvm similar to how react consumes core
2+
load("@build_constants//:constants.bzl", "GROUP")
23
load("@rules_jvm_external//:defs.bzl", "artifact")
34
load("//helpers:android.bzl", "kt_android")
45

@@ -7,7 +8,7 @@ main_exports = [
78
]
89

910
main_deps = main_exports + [
10-
"//devtools/plugins/basic/jvm:plugin",
11+
"//devtools/plugins/basic/jvm:basic",
1112
]
1213

1314
main_resources = []
@@ -19,8 +20,8 @@ test_deps = [
1920
]
2021

2122
kt_android(
22-
name = "plugin-android",
23-
group = "com.intuit.playerui.plugins.devtools.basic",
23+
name = "basic-android",
24+
group = "%s.plugins" % GROUP,
2425
main_deps = main_deps,
2526
main_exports = main_exports,
2627
main_resources = main_resources,
@@ -30,5 +31,5 @@ kt_android(
3031

3132
alias(
3233
name = "android",
33-
actual = "plugin-android",
34+
actual = "basic-android",
3435
)

‎devtools/plugins/basic/android/src/main/AndroidManifest.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<manifest package="com.intuit.playerui.plugins.devtools.basic"
1+
<manifest package="com.intuit.playerui.devtools.plugins.basic"
22
xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:tools="http://schemas.android.com/tools">
44

devtools/plugins/basic/android/src/main/kotlin/com/intuit/playerui/plugins/devtools/basic/BasicAndroidDevtoolsPlugin.kt renamed to devtools/plugins/basic/android/src/main/kotlin/com/intuit/playerui/devtools/plugins/basic/BasicAndroidDevtoolsPlugin.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
package com.intuit.playerui.plugins.devtools.basic
1+
package com.intuit.playerui.devtools.plugins.basic
22

33
import androidx.annotation.StyleRes
44
import com.intuit.playerui.android.AndroidPlayer
55
import com.intuit.playerui.core.bridge.runtime.Runtime
66
import com.intuit.playerui.devtools.AndroidDevtoolsPlugin
7-
import com.intuit.playerui.plugins.devtools.basic.BasicDevtoolsPlugin.Module.BasicDevtoolsPlugin
8-
import com.intuit.playerui.plugins.devtools.basic.R
7+
import com.intuit.playerui.devtools.plugins.basic.BasicDevtoolsPlugin.Module.BasicDevtoolsPlugin
8+
import com.intuit.playerui.devtools.plugins.basic.R
99

1010
public class BasicAndroidDevtoolsPlugin(
1111
private val id: String,

‎devtools/plugins/basic/jvm/BUILD‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# Wrap core
2+
load("@build_constants//:constants.bzl", "GROUP")
23
load("@rules_jvm_external//:defs.bzl", "artifact")
34
load("//helpers:jvm.bzl", "kt_jvm")
45

@@ -18,11 +19,11 @@ test_deps = [
1819
]
1920

2021
kt_jvm(
21-
name = "plugin",
22-
group = "com.intuit.playerui.plugins.devtools.basic",
22+
name = "basic",
23+
group = "%s.plugins" % GROUP,
2324
main_deps = main_deps,
2425
main_exports = main_exports,
2526
main_resources = main_resources,
2627
test_deps = test_deps,
27-
test_package = "com.intuit.playerui.plugins.devtools.basic",
28+
test_package = "com.intuit.playerui.devtools.plugins",
2829
)

devtools/plugins/basic/jvm/src/main/kotlin/com/intuit/playerui/plugins/devtools/basic/BasicDevtoolsPlugin.kt renamed to devtools/plugins/basic/jvm/src/main/kotlin/com/intuit/playerui/devtools/plugins/basic/BasicDevtoolsPlugin.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.intuit.playerui.plugins.devtools.basic
1+
package com.intuit.playerui.devtools.plugins.basic
22

33
import com.intuit.playerui.core.bridge.Node
44
import com.intuit.playerui.core.bridge.runtime.Runtime

devtools/plugins/basic/jvm/src/test/kotlin/com/intuit/playerui/plugins/devtools/basic/BasicDevtoolsPluginTest.kt renamed to devtools/plugins/basic/jvm/src/test/kotlin/com/intuit/playerui/devtools/plugins/basic/BasicDevtoolsPluginTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
package com.intuit.playerui.plugins.devtools.basic
1+
package com.intuit.playerui.devtools.plugins.basic
22

33
import com.intuit.playerui.devtools.DevtoolsHandler
44
import com.intuit.playerui.devtools.DevtoolsPluginInteractionEvent
5-
import com.intuit.playerui.plugins.devtools.basic.BasicDevtoolsPlugin.Module.BasicDevtoolsPlugin
5+
import com.intuit.playerui.devtools.plugins.basic.BasicDevtoolsPlugin.Module.BasicDevtoolsPlugin
66
import com.intuit.playerui.utils.test.RuntimeTest
77
import org.junit.jupiter.api.Assertions.assertTrue
88
import org.junit.jupiter.api.Test

‎helpers/BUILD‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@ load("@rules_kotlin//kotlin:lint.bzl", "ktlint_config")
66
load("@rules_jvm_external//:defs.bzl", "artifact")
77

88
exports_files([
9+
"defs.bzl",
10+
"pom.tpl",
911
"tsup.config.ts.tmpl",
1012
"vitest.config.mts.tmpl",
11-
"defs.bzl",
1213
])
1314

1415
js_library(

‎helpers/android.bzl‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ def kt_android(
1919
main_opts = "//helpers:kt_main_options",
2020
unit_test_opts = "//helpers:kt_test_options",
2121
version = VERSION,
22+
pom_template = "//helpers:pom.tpl",
2223
**kwargs):
2324
_kt_android(
2425
name = name,
@@ -29,5 +30,6 @@ def kt_android(
2930
main_opts = main_opts,
3031
unit_test_opts = unit_test_opts,
3132
version = version,
33+
pom_template = pom_template,
3234
**kwargs
3335
)

‎helpers/jvm.bzl‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ def kt_jvm(
1010
main_opts = "//helpers:kt_main_options",
1111
test_opts = "//helpers:kt_test_options",
1212
version = VERSION,
13+
pom_template = "//helpers:pom.tpl",
1314
**kwargs):
1415
_kt_jvm(
1516
name = name,
@@ -19,5 +20,6 @@ def kt_jvm(
1920
test_opts = test_opts,
2021
test_package = test_package if test_package else group,
2122
version = version,
23+
pom_template = pom_template,
2224
**kwargs
2325
)

‎helpers/pom.tpl‎

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
3+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
4+
<modelVersion>4.0.0</modelVersion>
5+
6+
<name>Player UI Devtools - {artifactId}</name>
7+
<description>Developer tooling for the Player UI platform</description>
8+
<url>https://player-ui.github.io</url>
9+
<licenses>
10+
<license>
11+
<name>Apache License, Version 2.0</name>
12+
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
13+
</license>
14+
</licenses>
15+
<developers>
16+
<developer>
17+
<id>sugarmanz</id>
18+
<name>Jeremiah Zucker</name>
19+
<email>zucker.jeremiah@gmail.com</email>
20+
</developer>
21+
</developers>
22+
<scm>
23+
<connection>https://github.com/player-ui/devtools.git</connection>
24+
<developerConnection>https://github.com/player-ui/devtools.git</developerConnection>
25+
<tag>v{version}</tag>
26+
<url>https://github.com/player-ui/devtools.git</url>
27+
</scm>
28+
29+
<groupId>{groupId}</groupId>
30+
<artifactId>{artifactId}</artifactId>
31+
<version>{version}</version>
32+
<packaging>{type}</packaging>
33+
34+
<dependencies>
35+
{dependencies}
36+
</dependencies>
37+
</project>

0 commit comments

Comments
 (0)