TransportException: connection to server 'myServer.com:10011' lost

[MatthiasHeinz]

When calling

$tsServer = // some object containing the server config
$options = array("host" => $tsServer->getHost(), "port" => $tsServer->getQueryPort(), "timeout" => 10, "blocking" => true);
$object = new ServerQuery($options);

the ServerQuery::__destruct() and thus this->request("quit") is being called (c.f. https://github.com/planetteamspeak/ts3phpframework/blob/dev/src/Adapter/ServerQuery.php#L106).

This line used to catch Exception instead of AdapterException (c.f.

ts3phpframework/libraries/TeamSpeak3/Adapter/ServerQuery.php

Line 96 in 035d242

catch(Exception $e)

) which used to catch the TransportException thrown in readLine(...) (c.f. https://github.com/planetteamspeak/ts3phpframework/blob/dev/src/Transport/TCP.php#L162), when calling this->request("quit").

For that reason, the TransportException is thrown and not caught anymore.

[MatthiasHeinz]

2 possible quick resolutions come to mind:

1. Revert to catching Exception instead of AdapterException in ServerQuery::__destruct().
2. Add an additional catch-clause in ServerQuery::__destruct() for TransportException.

[MatthiasHeinz]

PR #195 might also resolve this issue.

[Sebbo94BY]

Nice analysis!

Adding a catch (TransportException) { return; } should also solve the issue, yeah.

I would need to double-check this, but it makes sense in theory.

But great. Then we have now two options to solve this issue:

• PR Remove throwing TransportException on readLine() #195
• Add additional catch-clause TransportException

Do you want to create a PR for your mentioned solution @MatthiasHeinz or shall I?

Then we only need to decide, which one the better is. 😅

I'm still waiting for feedback from @RoninDesign regarding this (and all other open PRs). 😢

If nobody reviews my PR soon, I can also simply merge them and then everyone can at least test the DEV branch.

[tturnerdev]

Appreciate the patience, #195 has been merged. Please reopen this if not resolved!

[MatthiasHeinz]

I'll probably test this next week and give you guys a nudge, if the issue still persists by then; because I'm not allowed to reopen this issue.

[MatthiasHeinz]

Unfortunately, #195 does not seem to resolve the issue entirely; instead the CPU spins in an endless loop.

When calling ServerQuery::__destruct() and thus this->request("quit"), the following loop in ServerQuery.php probably does not terminate anymore, which previously was broken out of by the thrown TransportException.

do {
    $str = $this->getTransport()->readLine();
    $rpl[] = $str;
} while ($str->section(TeamSpeak3::SEPARATOR_CELL) != TeamSpeak3::ERROR);

Now though, $this->getTransport()->readLine() terminates gracefully and thus does not break out of this loop.

Beware: The current issue probably concerns more than just the previously mentioned use-case!

[MatthiasHeinz]

@RoninDesign Would you mind to reopen this issue based on my previous post?

[Sebbo94BY]

@MatthiasHeinz I've created a pull request to hopefully fix this issue: #206

Can you please let me know, if this solves the issue for you? I'll also try to reproduce and test this change on my side.