Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Commit 9fe5a2b

Browse files
authored
Bugfix notarization rm staple (#686)
* temporary: rm stapling
1 parent 855bd75 commit 9fe5a2b

2 files changed

Lines changed: 14 additions & 11 deletions

File tree

.github/workflows/build-sign-notarize.yml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,10 @@ jobs:
230230
security unlock-keychain -p "$MACOS_CI_KEYCHAIN_PWD" build.keychain
231231
security import certificate.p12 -k build.keychain -P "$MACOS_CERTIFICATE_PWD" -T /usr/bin/codesign
232232
security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "$MACOS_CI_KEYCHAIN_PWD" build.keychain
233-
/usr/bin/codesign --force -s "$MACOS_CERTIFICATE_NAME" --options runtime dist/$ARM64_ZIP -v
234-
/usr/bin/codesign --force -s "$MACOS_CERTIFICATE_NAME" --options runtime dist/$X86_ZIP -v
233+
234+
# skip: codesigning might need to move this inside the electron-builder codesigning step
235+
# /usr/bin/codesign --force -s "$MACOS_CERTIFICATE_NAME" --options runtime dist/$ARM64_ZIP -v
236+
# /usr/bin/codesign --force -s "$MACOS_CERTIFICATE_NAME" --options runtime dist/$X86_ZIP -v
235237
# Notarize. Can take up to 10 minutes (and fail) asynchronously
236238
# sometimes this might fail because exact the same zip has been uploaded already
237239

@@ -259,15 +261,16 @@ jobs:
259261
unzip dist/$ARM64_ZIP -d dist/mac-arm64
260262
unzip dist/$X86_ZIP -d dist/mac
261263
262-
echo "Doing staple"
263-
xcrun stapler staple "dist/mac/tea.app"
264-
xcrun stapler staple "dist/mac-arm64/tea.app"
264+
# TODO: might need to move this to the electron-builder codesigning step from dmg is created
265+
# echo "Doing staple"
266+
# xcrun stapler staple "dist/mac/tea.app"
267+
# xcrun stapler staple "dist/mac-arm64/tea.app"
265268
266-
echo "Rezip files"
267-
rm dist/$ARM64_ZIP
268-
rm dist/$X86_ZIP
269-
tea zip -r dist/$ARM64_ZIP dist/mac-arm64/tea.app
270-
tea zip -r dist/$X86_ZIP dist/mac/tea.app
269+
# echo "Rezip files"
270+
# rm dist/$ARM64_ZIP
271+
# rm dist/$X86_ZIP
272+
# tea zip -r dist/$ARM64_ZIP dist/mac-arm64/tea.app
273+
# tea zip -r dist/$X86_ZIP dist/mac/tea.app
271274
272275
# prepare for DMG creation
273276
- name: prepare installer folders

modules/desktop/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "tea",
3-
"version": "0.2.33",
3+
"version": "0.2.34",
44
"private": true,
55
"description": "tea gui app",
66
"author": "tea.xyz",

0 commit comments

Comments
 (0)